Skip to content

Commit

Permalink
Merge pull request #4203 from MikeSpreitzer/apf-mostly-ga
Browse files Browse the repository at this point in the history
KEP-1040: Check off most remaining GA criteria
  • Loading branch information
k8s-ci-robot authored Sep 14, 2023
2 parents 1dd0bad + 009eb6e commit c0b7032
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions keps/sig-api-machinery/1040-priority-and-fairness/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -3013,10 +3013,10 @@ GA:
- [x] API annotations properly support strategic merge patch.
- [x] Design and implement borrowing between priority levels.
- [ ] Satisfaction with LIST and WATCH support.
- [ ] Implement borrowing by exempt priority levels.
- [ ] APF allows us to disable client-side rate limiting without causing the apiservers to wedge/crash. Note that there is another level of concern that APF does not attempt to address, which is mismatch between the throughput that various controllers can sustain.
- [ ] Satisfaction that the interface is sufficient to support tuning of capacity and resource costs.
- [x] Satisfaction that LIST and WATCH support are good enough.
- [x] Implement borrowing by exempt priority levels.
- [x] APF allows us to disable client-side rate limiting without causing the apiservers to wedge/crash. Note that this falls a bit short of saying that we would actually want to disable client-side rate limiting. While experiments show that APF can prevent server crashes, they do not show that the SLOs are met in all scenarios. If the control plane is under-provisioned then the performance will have to suffer in one way or another.
- [x] Satisfaction that the interface has sufficient tunability to be useful.
- [ ] Setting `--enable-priority-and-fairness` to `false` disables deeply, including suppressing both the config supplying and config consuming controllers.
### Upgrade / Downgrade Strategy
Expand Down
4 changes: 2 additions & 2 deletions keps/sig-api-machinery/1040-priority-and-fairness/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,13 @@ stage: stable
# The most recent milestone for which work toward delivery of this KEP has been
# done. This can be the current (upcoming) milestone, if it is being actively
# worked on.
latest-milestone: "v1.27"
latest-milestone: "v1.29"

# The milestone at which this feature was, or is targeted to be, at each stage.
milestone:
alpha: "v1.18"
beta: "v1.20"
stable: "v1.28"
stable: "v1.29"

# The following PRR answers are required at alpha release.
# List the feature gate name and the components for which it must be enabled.
Expand Down

0 comments on commit c0b7032

Please sign in to comment.