Skip to content

Commit

Permalink
sidecar container KEP
Browse files Browse the repository at this point in the history
  • Loading branch information
SergeyKanzhelev committed Feb 9, 2023
1 parent d72f3e3 commit 9494d2c
Showing 1 changed file with 6 additions and 4 deletions.
10 changes: 6 additions & 4 deletions keps/sig-node/753-sidecar-containers/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -988,11 +988,13 @@ So when the new functionality wasn't yet used, downgrade will not be affected.

Due to the new field added to `initContainers` to turn them into sidecars,
downgrading to the version without this feature will make all Pods using this
flag unscheduleable. These Pod spec will be rejected by the control plane and
all kubelets during unmarshalling.
flag unscheduleable. New Pods will be rejected by the control plane and
all kubelets. Pods that has already been created will not be rejected by control
plane, but once reaching the kubelet, that has this feature disabled or which
is old, kubelet will reject the Pod on unmarshalling.

**Note**, this specific behavior on read is not clear and if unmarshaling works,
the new logic to reject such Pods will be added.
**Note**, we tested kubelet behavior. For the control plane we may need
to implement a new logic to reject such Pods when feature gate got turned off.
See [Upgrade/downgrade testing](#upgradedowngrade-testing) section.

Workloads will have to be deleted and recreated with the old way of handling
Expand Down

0 comments on commit 9494d2c

Please sign in to comment.