Merge pull request #3423 from nabokihms/3325-update-tests-plan

KEP-3325: Update test plan section

keps/sig-auth/3325-self-subject-attributes-review-api/README.md

@@ -11,6 +11,10 @@
   - [Request](#request)
   - [RBAC](#rbac)
   - [Test Plan](#test-plan)
+      - [Prerequisite testing updates](#prerequisite-testing-updates)
+      - [Unit tests](#unit-tests)
+      - [Integration tests](#integration-tests)
+      - [e2e tests](#e2e-tests)
   - [Graduation Criteria](#graduation-criteria)
     - [Alpha](#alpha)
     - [Beta](#beta)
@@ -175,21 +179,76 @@ If necessary, it will be possible to disable this API by using the following kub
 
 ### Test Plan
 
-Unit tests covering:
+[X] I/we understand the owners of the involved components may require updates to
+existing tests to make this code solid enough prior to committing the changes necessary
+to implement this enhancement.
+
+##### Prerequisite testing updates
+
+<!--
+Based on reviewers feedback describe what additional tests need to be added prior
+implementing this enhancement to ensure the enhancements have also solid foundations.
+-->
+
+N/A
+
+##### Unit tests
+
+<!--
+In principle every added code should have complete unit test coverage, so providing
+the exact set of tests will not bring additional value.
+However, if complete unit test coverage is not possible, explain the reason of it
+together with explanation why this is acceptable.
+-->
+
+<!--
+Additionally, for Alpha try to enumerate the core package you will be touching
+to implement this enhancement and provide the current unit coverage for those
+in the form of:
+- <package>: <date> - <current test coverage>
+The data can be easily read from:
+https://testgrid.k8s.io/sig-testing-canaries#ci-kubernetes-coverage-unit
+This can inform certain test coverage improvements that we want to do before
+extending the production code to implement this enhancement.
+-->
+
+The plan to test the SelfSubjectAttributesReview API is:
 
 1. Request returns all user attributes
 2. Request returns some user attributes
 3. Request with a status returns overridden fields
 
-Integration tests covering:
+Command line interface tests covering:
+1. How successful responses are rendered in the terminal with various output modes.
+2. How errors are rendered.
+
+Given that a new API package is introduced as part of this feature there is
+no existing test coverage to link to.
+
+##### Integration tests
+
+<!--
+This question should be filled when targeting a release.
+For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
+For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
+https://storage.googleapis.com/k8s-triage/index.html
+-->
 
 1. Successful authentication through a simple authenticator, e.g., token or certificate authenticator
 2. Successful authentication through a complicated authenticator, e.g., webhook or authentication proxy authenticator
 3. Failed authentication
 
-Command line interface tests covering:
-1. How successful responses are rendered in the terminal with various output modes.
-2. How errors are rendered.
+##### e2e tests
+
+<!--
+This question should be filled when targeting a release.
+For Alpha, describe what tests will be added to ensure proper quality of the enhancement.
+For Beta and GA, add links to added tests together with links to k8s-triage for those tests:
+https://storage.googleapis.com/k8s-triage/index.html
+We expect no non-infra related flakes in the last month as a GA graduation criteria.
+-->
+
+There are no e2e tests planned for the alpha milestone.
 
 ### Graduation Criteria