Skip to content

Commit

Permalink
fix typo
Browse files Browse the repository at this point in the history
Signed-off-by: Byonggon Chun <[email protected]>
  • Loading branch information
Byonggon Chun committed Sep 2, 2019
1 parent aa43ea9 commit 54911ed
Showing 1 changed file with 5 additions and 12 deletions.
17 changes: 5 additions & 12 deletions keps/sig-node/20190129-hugepages.md
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ superseded-by:
- [cAdvisor changes(Phase 1)](#cadvisor-changes(Phase-1))
- [Phase 2](#Phase-2)
- [Support container isolation of huge pages](#support-container-isolation-of-huge-pages)
- [Support reserve huge pages for system on Node Allocatable feature](#support-reserve-huge-pages-for-system-on-node-allocatable-feature)
- [Enhance Node Allocatable feature to reserve huge pages for system](#enhance-node-allocatable-feature-to-reserve-huge-pages-for-system)
- [cAdviser changes(Phase 2)](#cAdviser-changes(Phase-2))
- [Phase 3](#Phase-3)
- [Update LinuxContainerResources(CRI) to support specifying huge page limits](#update-linuxcontainerresources(cri)-to-support-specifying-huge-page-limits)
Expand Down Expand Up @@ -335,20 +335,13 @@ calculate allocatable values on the node.

#### Support container isolation of huge pages

Container isolation of huge pages should be supported to avoid competition between containers to consume huge pages. Currently, `kubelet` sets the agregated huge pages limits on pod's cgroup of hugetlb subsystem. This should be enhanced to set limits on container's cgroup.
Container isolation of huge pages should be supported to avoid competition between containers to consume huge pages. Currently, `kubelet` directly sets the aggregated huge pages limits on pod's cgroup of hugetlb subsystem. The limits should be set on a container's cgroup. To achieve this, the `LinuxContainerResources` message which is used to update the container resource should be updated to specify huge page limits per container. `containerd` also should be updated to handle huge page.

#### cAdviser changes(Phase 2)
To support NUMA, `cAdviser` should collect and store pre-allocated huge pages per NUMA node.
To support NUMA, `cAdviser` should discover and store pre-allocated huge pages per NUMA node. The `v3` version of `MachineInfo` will be introduced.


#### Support reserve huge pages for system on Node Allocatable feature
Some system services like `OVS-DPDK` comsume huge pages per NUMA node, to determine allocatalbe number of huge pages in `kubelet`, `Node Allocatable feature` should support to reserve huge pages per NUMA node.

### Phase 3

##### Update LinuxContainerResources(CRI) to support specifying huge page limits

To set huge page limits through systemd by using CRI, `LinuxContainerResources` message should be updated to specify huge page limits. `systemd` also should be updated to handle huge page.
#### Enhance Node Allocatable feature to reserve huge pages for system
Some system services like `OVS-DPDK` comsume huge pages per NUMA node, to determine the allocatalbe number of huge pages in `kubelet`, `Node Allocatable feature` should support to reserve huge pages per NUMA node.

### Risks and Mitigations

Expand Down

0 comments on commit 54911ed

Please sign in to comment.