Skip to content

Commit

Permalink
Add some more answers into PRR review in EndPort kep
Browse files Browse the repository at this point in the history
Signed-off-by: Ricardo Pchevuzinske Katz <[email protected]>
  • Loading branch information
rikatz committed Dec 21, 2020
1 parent 545a17c commit 5095f41
Show file tree
Hide file tree
Showing 2 changed files with 28 additions and 7 deletions.
32 changes: 26 additions & 6 deletions keps/sig-network/2079-network-policy-port-range/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -232,20 +232,40 @@ _This section must be completed when targeting alpha to a release._

* **Can the feature be disabled once it has been enabled (i.e. can we roll back
the enablement)?**
Yes, but CNIs relying on the new field wont recognize it anymore
Yes, but CNIs relying on the new field wont recognize it anymore. Also,
because this is a Feature Gate'd API field, disabling the feature gate and
updating a Network Policy with existing EndPort field will remove this field.

* **What happens if we reenable the feature if it was previously rolled back?**
Nothing. Just need to check if the data is persisted in `etcd` after the
feature is disabled and reenabled or if the data is missed
feature is disabled and reenabled. If the object "NetworkPolicy" is updated
during this time window between disabling and re-enabling the EndPort field
from this object might be removed by PrepareForUpdate function.

* **Are there any tests for feature enablement/disablement?**

TBD
Yes, and the tests are already being implemented in the REST stragegy package
for NetworkPolicy.

### Monitoring Requirements
### Rollout, Upgrade and Rollback Planning

_This section must be completed when targeting beta graduation to a release._
* **How can a rollout fail? Can it impact already running workloads?**
Nothing happens, this is a new Network Policy API Field

* **What specific metrics should inform a rollback?**
None

* **Were upgrade and rollback tested? Was the upgrade->downgrade->upgrade path tested?**
TBD / This tests should be done with a defined CNI, so as soon as CNIs starts
supporting the new field (by the graduation criteria, at least 4) this should be tested.

* **Is the rollout accompanied by any deprecations and/or removals of features, APIs,
None

### Monitoring Requirements

_This section must be completed when targeting beta graduation to a release._
* **How can an operator determine if the feature is in use by workloads?**

Operators can determine if NetworkPolicies are making use of EndPort creating
Expand Down Expand Up @@ -282,10 +302,10 @@ _For GA, this section is required: approvers should be able to confirm the
previous answers based on experience in the field._

* **Will enabling / using this feature result in any new API calls?**
TBD
No

* **Will enabling / using this feature result in introducing new API types?**
No, unless the new `EndPort` is considered a new API type
No

* **Will enabling / using this feature result in any new calls to the cloud
provider?**
Expand Down
3 changes: 2 additions & 1 deletion keps/sig-network/2079-network-policy-port-range/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ reviewers:
- "@danwinship"
approvers:
- "@thockin"

prr-approvers:
- "@wojtek-t"
# The target maturity stage in the current dev cycle for this KEP.
stage: alpha

Expand Down

0 comments on commit 5095f41

Please sign in to comment.