Skip to content

Commit

Permalink
Mitigate number of status updates
Browse files Browse the repository at this point in the history
  • Loading branch information
alculquicondor committed Sep 1, 2021
1 parent 2684cc5 commit 24e1c4c
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 6 deletions.
12 changes: 7 additions & 5 deletions keps/sig-apps/2879-ready-pods-job-status/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,10 @@ field based on the number of Pods that have the `Ready` condition.

### Risks and Mitigations

An increase in Job status updates. This is capped by the number of times Pods
reach the ready State, usually once in their lifetime.
- An increase in Job status updates. To mitigate this, the job controller holds
the Pod updates that happen in X ms before syncing a Job. X will be determined
from experiments on integration tests, but we expect it to be between 100ms
and 1s.

## Design Details

Expand Down Expand Up @@ -189,7 +191,7 @@ The Job controller will start populating the field again.

###### Are there any tests for feature enablement/disablement?

Yes, at unit and integration level.
Yes, there will be tests at unit and integration level.

### Rollout, Upgrade and Rollback Planning

Expand Down Expand Up @@ -222,8 +224,8 @@ The feature applies to all Jobs, unless the feature gate is disabled.

###### What are the reasonable SLOs (Service Level Objectives) for the enhancement?

The 99% percentile of Job status updates below 1s, when the controller doesn't
create new Pods or tracks finishing Pods.
The 99% percentile of Job status sync (processing+API calls) is below 2s, when
the controller doesn't create new Pods or tracks finishing Pods.

###### What are the SLIs (Service Level Indicators) an operator can use to determine the health of the service?

Expand Down
3 changes: 2 additions & 1 deletion keps/sig-apps/2879-ready-pods-job-status/kep.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,8 @@ stage: alpha
latest-milestone: "v1.23"

milestone:
beta: "v1.23"
alpha: "v1.23"
beta: "v1.24"
stable: "v1.25"

feature-gates:
Expand Down

0 comments on commit 24e1c4c

Please sign in to comment.