Skip to content

Commit

Permalink
Added metric
Browse files Browse the repository at this point in the history
  • Loading branch information
soltysh committed Feb 1, 2022
1 parent 82eb73a commit 09a41a1
Showing 1 changed file with 10 additions and 4 deletions.
14 changes: 10 additions & 4 deletions keps/sig-apps/3140-TimeZone-support-in-CronJob/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,9 @@ there are a few cases:
should be no change in behavior.
3. If TimeZone feature gate was not enabled there should be no change in behavior.

Irrespectively of the option, cluster administrator should monitor `cronjob_job_creation_skew`
which reports the skew between schedule and actual job creation.

### Version Skew Strategy

This feature has no node runtime implications.
Expand Down Expand Up @@ -286,6 +289,10 @@ rollout. Similarly, consider large clusters and how enablement/disablement
will rollout across nodes.
-->

An upgrade flow can be vulnerable to the enable, disable, enable if you have
a lease that is acquired by a new kube-controller-manager, then an old
kube-controller-manager, then a new kube-controller-manager.

###### What specific metrics should inform a rollback?

<!--
Expand Down Expand Up @@ -363,10 +370,9 @@ question.
Pick one more of these and delete the rest.
-->

- [ ] Metrics
- Metric name:
- [Optional] Aggregation method:
- Components exposing the metric:
- [x] Metrics
- Metric name: `cronjob_controller_rate_limiter_use`
- Components exposing the metric: `kube-controller-manager`
- [ ] Other (treat as last resort)
- Details:

Expand Down

0 comments on commit 09a41a1

Please sign in to comment.