Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to dnsmasq v2.90 #623

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

DamianSawicki
Copy link
Collaborator

The new dnsmasq version is officially released. Among other things, it

  • enables increasing the number of concurrent TCP connections, previously hardcoded as 20,
  • fixes the bug causing memory leaks for records with TTL=0.

Among other things, the new version
 * enables increasing the number of concurrent TCP connections,
   previously hardcoded as 20
   (commit 416390f9962e455769aa8ab6df0e105cae07ae55),
 * fixes the bug causing memory leaks for records with TTL=0
   (commit 8b606543a3fb687f0e49d4e832f98be9a08924d0).
@k8s-ci-robot
Copy link
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 14, 2024
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 14, 2024
@DamianSawicki
Copy link
Collaborator Author

/ok-to-test

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Feb 14, 2024
@DamianSawicki
Copy link
Collaborator Author

/cc wewark
/cc tangenti

@k8s-ci-robot
Copy link
Contributor

@DamianSawicki: GitHub didn't allow me to request PR reviews from the following users: wewark, tangenti.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc wewark
/cc tangenti

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@DamianSawicki DamianSawicki marked this pull request as ready for review February 14, 2024 14:27
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 14, 2024
@kl52752
Copy link
Collaborator

kl52752 commented Feb 14, 2024

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DamianSawicki, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit f90ba1b into kubernetes:master Feb 14, 2024
3 checks passed
@aojea
Copy link
Member

aojea commented Feb 14, 2024

do we want to use a larger number of concurrent tcp connections by default?

@bowei
Copy link
Member

bowei commented Feb 14, 2024

Can we do a small experiment to understand if we can raise it further (TCP)

@DamianSawicki
Copy link
Collaborator Author

DamianSawicki commented Feb 14, 2024

do we want to use a larger number of concurrent tcp connections by default?

My plan is to first only upgrade the image here (no behaviour change). IIUC, all flags for dnsmasq are set internally, and OSS dnsmasq-nanny just passes them, so let's move the discussion to internal channels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants