Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run kubelet in the E2E test mock cluster #606

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Don't run kubelet in the E2E test mock cluster #606

merged 1 commit into from
Oct 26, 2023

Conversation

jingyuanliang
Copy link
Contributor

@jingyuanliang jingyuanliang commented Oct 24, 2023 •
edited
Loading

The existing E2E tests don't need kubelet (proven as this commit still
passing presubmit), while the execution of kubelet started to cause
mysterious failures recently (#605). Let's exclude kubelet in the mock
cluster for now. Not completely removing the relevant code in case some
future tests need them, then #605 can be investigated at that time.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 24, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 24, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @jingyuanliang. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 24, 2023
@MrHohn
Copy link
Member

MrHohn commented Oct 24, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 24, 2023
@bowei
Copy link
Member

bowei commented Oct 24, 2023

Can we have more details on the commit message on why this change is being done?

@jingyuanliang jingyuanliang changed the title kubelet Don't run kubelet in the E2E test mock cluster Oct 24, 2023
@jingyuanliang
Copy link
Contributor Author

/hold
Just pushed to run the test. Will amend for commit messages etc.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@jingyuanliang
Copy link
Contributor Author

Can we have more details on the commit message on why this change is being done?

Done. And the test execution above https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/dns/606/pull-kubernetes-dns-test/1716879667937415168 completed without failure.

@jingyuanliang
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 24, 2023
@jingyuanliang
Copy link
Contributor Author

cc @wewark

@jingyuanliang
Don't run kubelet in the E2E test mock cluster
e907bf6 
The existing E2E tests don't need kubelet (proven as this commit still
passing presubmit), while the execution of kubelet started to cause
mysterious failures recently (kubernetes#605). Let's exclude kubelet in the mock
cluster for now. Not completely removing the relevant code in case some
future tests need them, then kubernetes#605 can be investigated at that time.
@kl52752
Copy link
Collaborator

kl52752 commented Oct 26, 2023

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jingyuanliang, kl52752

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot merged commit 53338f8 into kubernetes:master Oct 26, 2023
3 checks passed
@ty-dc ty-dc mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bowei bowei Awaiting requested review from bowei

@MrHohn MrHohn Awaiting requested review from MrHohn

Assignees

@kl52752 kl52752

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jingyuanliang @k8s-ci-robot @MrHohn @bowei @kl52752