Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some go style mistakes about fmt.Errorf #16

Merged
merged 2 commits into from
Jan 4, 2017

Conversation

chentao1596
Copy link

I think we should follow this request: https://github.com/golang/go/wiki/CodeReviewComments#error-strings, thank you!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 31, 2016
@chentao1596
Copy link
Author

@bowei @MrHohn hi, cc, thank you!

Copy link
Member

@bowei bowei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bowei bowei merged commit dd1d082 into kubernetes:master Jan 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants