Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip: feat(client): add optional in-memory cache to client #9521

Draft
wants to merge 24 commits into
base: master
Choose a base branch
from

Conversation

floreks
Copy link
Member

@floreks floreks commented Oct 14, 2024

TBD

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 14, 2024
@floreks floreks changed the title feat(client): add optional in-memory cache to client wip: feat(client): add optional in-memory cache to client Oct 14, 2024
@floreks floreks marked this pull request as draft October 14, 2024 15:42
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 14, 2024
@floreks floreks self-assigned this Oct 14, 2024
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 8.67209% with 337 lines in your changes missing coverage. Please review.

Project coverage is 36.41%. Comparing base (31d5f5d) to head (02b6776).
Report is 24 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #9521      +/-   ##
==========================================
- Coverage   37.08%   36.41%   -0.68%     
==========================================
  Files         283      295      +12     
  Lines       11830    12068     +238     
  Branches      202      183      -19     
==========================================
+ Hits         4387     4394       +7     
- Misses       7168     7452     +284     
+ Partials      275      222      -53     

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 15, 2024
@floreks floreks added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 15, 2024
@k8s-ci-robot k8s-ci-robot removed the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Oct 16, 2024
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants