Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test intro for i18n #5694

Merged
merged 4 commits into from
Nov 26, 2020
Merged

add test intro for i18n #5694

merged 4 commits into from
Nov 26, 2020

Conversation

helight
Copy link
Contributor

@helight helight commented Nov 24, 2020

When I test for my local language, I found that it didn't work.
At last I found that we should use this command for my test: npm start.

we should use this npm run start:prod for my local test for i18n. but this is not mentioned in the document.

So I add some note. Please guy help to check if it is ok.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 24, 2020
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #5694 (5c9b22f) into master (cb66bd2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5694   +/-   ##
=======================================
  Coverage   44.37%   44.37%           
=======================================
  Files         214      214           
  Lines        9119     9119           
  Branches      113      113           
=======================================
  Hits         4047     4047           
  Misses       4797     4797           
  Partials      275      275           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb66bd2...5c9b22f. Read the comment docs.

@helight helight requested a review from floreks November 26, 2020 04:45
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 26, 2020
@floreks
Copy link
Member

floreks commented Nov 26, 2020

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, helight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 26, 2020
@k8s-ci-robot k8s-ci-robot merged commit 5264516 into kubernetes:master Nov 26, 2020
@helight helight deleted the add_test_intro_for_i18n branch November 26, 2020 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants