Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prod build for macOS #4235

Merged
merged 1 commit into from
Aug 29, 2019
Merged

Fix prod build for macOS #4235

merged 1 commit into from
Aug 29, 2019

Conversation

maciaszczykm
Copy link
Member

GOOS is set automatically, no need to block it only for linux.

@maciaszczykm maciaszczykm requested a review from jeefy August 29, 2019 13:00
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 29, 2019
@floreks
Copy link
Member

floreks commented Aug 29, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 29, 2019
@k8s-ci-robot k8s-ci-robot requested review from floreks and mhenc August 29, 2019 13:01
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, maciaszczykm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [floreks,maciaszczykm]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #4235 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4235      +/-   ##
==========================================
+ Coverage   45.94%   45.95%   +0.01%     
==========================================
  Files         198      198              
  Lines        9298     9298              
  Branches      105      105              
==========================================
+ Hits         4272     4273       +1     
+ Misses       4766     4765       -1     
  Partials      260      260
Impacted Files Coverage Δ
...p/backend/integration/metric/common/aggregation.go 90.9% <0%> (+1.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24b04c5...d771875. Read the comment docs.

@k8s-ci-robot k8s-ci-robot merged commit 1988497 into kubernetes:master Aug 29, 2019
@maciaszczykm maciaszczykm deleted the fix/mac-build branch August 29, 2019 13:18
@shu-mutou
Copy link
Contributor

closes #4128

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants