-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove redundant namespace filters #3877
Remove redundant namespace filters #3877
Conversation
e5c641d
to
acd3231
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eloyekunle The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## master #3877 +/- ##
==========================================
+ Coverage 46.56% 46.94% +0.37%
==========================================
Files 173 173
Lines 8066 8001 -65
Branches 59 59
==========================================
Hits 3756 3756
+ Misses 4080 4015 -65
Partials 230 230
Continue to review full report at Codecov.
|
Not sure about this anymore. Indeed @floreks Was this intended? Can we pick let's say 2 or 3 namespaces somewhere (not all of them)? |
You're right @maciaszczykm, |
Okay then, let's close it as it has some function. /close |
@maciaszczykm: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
In
resourcechannels.go
, REST queries already filtered by namespace should no longer be filtered by the filtering loop.