upgrade hugo, swap to hugo modules, upgrade docsy #456
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jeefy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
|
The preview has some styling errors, presumably from the Docsy update. I can start trying to chase them down but any help there would be appreciated. 🙃 /hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
Pretty sure I fixed the CSS issues post-upgrade /hold cancel /assign @mrbobbytables |
k8s-ci-robot
removed
the
do-not-merge/hold
There was a problem hiding this comment.
Was this addition accidental?^^;;
There was a problem hiding this comment.
The grep command changes broke link detection. =/ Even small changes to these tend to break links in some way.
- "Community Expectations" generates a link with:
/docs/guide/expectations.mdwhen it should be/docs/guide/expectations(does not strip trailing md and link 404's)
It's the case for a good chunk of the links across the pages. I looked at various others in the guide section and its like that.
There was a problem hiding this comment.
There are few more issues in addition to the concerns highlighted in review comment #456 (review) regarding the main navigation bar and the absence of a search feature. Specifically, the mobile view for smaller screens, unfortunately has some issues such as the navigation bar size seems to be cutting off text and the hamburger menu for navigating between pages is non-functional.
Deploy Preview
(Attached the screenshot below for reference)
|
The links in https://www.kubernetes.dev/docs/contributor-cheatsheet/ to other languages work, but the links in https://deploy-preview-456--kubernetes-contributor.netlify.app/docs/contributor-cheatsheet/ do not. Can we fix that before this gets LGTM? |
|
@jeefy what would you like to happen about #456 (comment)? I can try to rally some help there (if you'd like it). |
k8s-ci-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
k8s-ci-robot
added
lifecycle/rotten
|
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
|
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
hugo modhack/gen-content.shto suppressgrepwarnings (see New grep versions and warnings about stray / koalaman/shellcheck#2573 for example)gen-contentrun.