Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIG Architecture Conformance spotlight interview #431

Merged

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented Sep 8, 2023

Spotlight article on SIG Architecture: Conformance, the first of the series.

Closes: #436

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 8, 2023
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Sep 8, 2023

I'm still making another review pass

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2023
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Sep 8, 2023

/retitle: WIP: Add SIG Architecture Conformance spotlight interview

@k8s-ci-robot k8s-ci-robot changed the title WIP: SIG Architecture Conformance spotlight interview : WIP: Add SIG Architecture Conformance spotlight interview Sep 8, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2023
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Sep 8, 2023

/cc @Riaankl

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Sep 8, 2023

/retitle WIP: Add SIG Architecture Conformance spotlight interview

@k8s-ci-robot k8s-ci-robot changed the title : WIP: Add SIG Architecture Conformance spotlight interview WIP: Add SIG Architecture Conformance spotlight interview Sep 8, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 8, 2023
@riaankleinhans
Copy link

/cc @Riaankl

Looking good. Thank you.

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Sep 22, 2023

/unhold
/retitle Add SIG Architecture Conformance spotlight interview

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 22, 2023
@k8s-ci-robot k8s-ci-robot changed the title WIP: Add SIG Architecture Conformance spotlight interview Add SIG Architecture Conformance spotlight interview Sep 22, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 22, 2023
Copy link
Contributor

@chris-short chris-short left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Typo and two suggestions for you to think over.

@sftim
Copy link
Contributor

sftim commented Sep 24, 2023

/hold
publication date not yet confirmed

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 24, 2023
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Sep 28, 2023

New date added, Oct 5 @sftim . I've reflected the suggestions up until this point @chris-short @Riaankl , do take a quick look at the latest commit, thanks!

@sftim
Copy link
Contributor

sftim commented Oct 5, 2023

/hold cancel
/lgtm
/approve

Thanks

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 5, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 5, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 5, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5a166b6 into kubernetes:master Oct 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Development

Successfully merging this pull request may close these issues.

Do a spotlight on SIG Architecture: Conformance subproject.
5 participants