Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIG CLI Spotlight blog article #411

Merged
merged 1 commit into from
Jul 13, 2023

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented Jul 9, 2023

SIG CLI Spotlight article.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 9, 2023
@k8s-ci-robot k8s-ci-robot requested review from jeefy and sftim July 9, 2023 12:44
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 9, 2023
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 9, 2023

Please review and confirm, especially because while editing I've added some small changes like the links to the GitHub profiles, maybe you prefer to link to Twitter or somewhere else.

/cc @KnVerey @soltysh

@k8s-ci-robot k8s-ci-robot requested review from KnVerey and soltysh July 9, 2023 12:49
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 9, 2023

/cc @arpitjindal97

@k8s-ci-robot
Copy link
Contributor

@fsmunoz: GitHub didn't allow me to request PR reviews from the following users: arpitjindal97.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @arpitjindal97

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@arpitjindal97
Copy link

You guys tagged wrong Arpit 😆

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 10, 2023

@arpitjindal97 apologies, will correct the commit, thanks for the heads-up!

@fsmunoz fsmunoz force-pushed the sig-cli-spotlight branch from 39438a8 to bf929fb Compare July 10, 2023 11:51
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 10, 2023

/uncc @arpitjindal97

@sftim
Copy link
Contributor

sftim commented Jul 10, 2023

It would be nice to have a PR against k/website ready so that we mirror this article there (with this one as canonical)

See other articles in this series for hints about how we've done that.

@sftim
Copy link
Contributor

sftim commented Jul 10, 2023

/retitle Add SIG CLI Spotlight blog article

@k8s-ci-robot k8s-ci-robot changed the title SIG CLI Spotlight article. Add SIG CLI Spotlight blog article Jul 10, 2023
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 10, 2023

@sftim sure, added kubernetes/website#41973 for the website.

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 13, 2023

Going to change the publishing date header if no updates during the day .

@fsmunoz fsmunoz force-pushed the sig-cli-spotlight branch from b670d9e to b445a97 Compare July 13, 2023 13:16
@sftim
Copy link
Contributor

sftim commented Jul 13, 2023

I expected that kubernetes/website#41973 would be filled in a lot more. I'd prefer to wait until both are ready to go.

/hold

How about bumping these both back 7 days, and filling in kubernetes/website#41973 so that it previews OK? Have a look at other SIG spotlight article PRs in k/website to see how this is done.

OK to unhold once the other PR is reviewable.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 13, 2023

Hi @sftim, thanks for the comments. I kept it empty on purpose, for two reasons:

  • If we are doing the review here until it's ready, it would be a waste of time to replicate each change to the other one. Since I had no indication that this one was already completely reviewed, I didn't update the other one.
  • In previous SIG Spotlight articles (like Add SIG Storage Spotlight website#35084 ), it was explicitly mentioned that it should first be approved here, and then "copied" to the other - which makes sense and avoids work, but my understanding of this was to push a placeholder there and wait for the document to be ready here before doing the "copying"

I can easily push a commit to the other one right now, with the existing content, and changing the publishing date as suggested. We should then better document the process (I can update the blogging guidelines we have in Comms).

@sftim
Copy link
Contributor

sftim commented Jul 13, 2023

I can easily push a commit to the other one right now, with the existing content, and changing the publishing date as suggested. We should then better document the process (I can update the blogging guidelines we have in Comms).

Cool, let's do that.

Co-authored-by: Arpit Agrawal <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
@fsmunoz fsmunoz force-pushed the sig-cli-spotlight branch from b445a97 to 71d05ed Compare July 13, 2023 15:02
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 13, 2023

Changed date, rebased, updated kubernetes/website#41973 with existing content, as discussed!

@sftim
Copy link
Contributor

sftim commented Jul 13, 2023

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2023
@sftim
Copy link
Contributor

sftim commented Jul 13, 2023

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 88286c5 into kubernetes:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants