Add SIG Docs Spotlight blog article #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotlight blog series - SIG Docs edition
k8s-ci-robot
added
cncf-cla: yes
|
/retitle Add SIG Docs Spotlight blog article |
k8s-ci-robot
changed the title
|
cc @sftim |
sftim
reviewed
Jul 24, 2022
There was a problem hiding this comment.
- I recommend using underscores (
_) not spaces in the filename. - The Markdown source is easier to review if it's wrapped to say 100 character lines.
- Other articles have mostly not put a “Q.” prefix questions in headings. Have a look at https://www.k8s.dev/blog/2022/02/04/sig-multicluster-spotlight-2022/ and https://kubernetes.io/blog/2021/09/27/sig-node-spotlight-2021/
I'd omit that prefix. - Let's pick a publication date. How about the 5th of August (is that too far away? if so, how about the 29th of July)
k8s-ci-robot
added
size/L
|
@sftim the changes are in and chose July 29th as the DOP |
sftim
reviewed
Jul 26, 2022
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
sftim
reviewed
Jul 27, 2022
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
@PurneswarPrasad after updating, please copy the article text into a new k/website PR that is similar to kubernetes/website#35084 |
Co-authored-by: Tim Bannister <[email protected]>
k8s-ci-robot
removed
the
lgtm
Co-authored-by: Tim Bannister <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
|
I'm happy with this. |
k8s-ci-robot
added
the
lgtm
|
/hold Needs approval. Update the publication date if approving after 2022-07-29. |
k8s-ci-robot
added
the
do-not-merge/hold
mrbobbytables
added
the
tide/merge-method-squash
k8s-ci-robot
removed
the
lgtm
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jberkus, PurneswarPrasad, sftim The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
kubernetes/website#35530 is good to go. |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spotlight blog series - SIG Docs edition