Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SIG Storage Spotlight blog article #319

Merged
merged 12 commits into from
Aug 22, 2022
Merged

Add SIG Storage Spotlight blog article #319

merged 12 commits into from
Aug 22, 2022

Conversation

fsmunoz
Copy link
Contributor

@fsmunoz fsmunoz commented Jul 17, 2022

Interview with SIG-Storage as part of the SIG-ContribEx comms series "Spotlight on..."

/cc @xing-yang

@k8s-ci-robot k8s-ci-robot requested a review from xing-yang July 17, 2022 12:27
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2022
@fsmunoz fsmunoz mentioned this pull request Jul 17, 2022
Merged
@sftim
Copy link
Contributor

sftim commented Jul 17, 2022

/retitle Add SIG Storage Spotlight blog article

@k8s-ci-robot k8s-ci-robot changed the title Add SIG-Storage Spotlight Add SIG Storage Spotlight blog article Jul 17, 2022
sftim
sftim reviewed Jul 17, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Here's a review.

content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
content/en/blog/2022/SIG-Storage Spotlight.md Outdated Show resolved Hide resolved
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 17, 2022

@sftim I've added those suggestions which weren't directly commitable in my last commit, I think it covers everything.

fsmunoz and others added 8 commits July 17, 2022 18:34
@fsmunoz
Add SIG-Storage Spotlight
eff7085 
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz @sftim
Update content/en/blog/2022/SIG-Storage Spotlight.md
9f93bb8 
Co-authored-by: Tim Bannister <[email protected]>
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz @sftim
Update content/en/blog/2022/SIG-Storage Spotlight.md
888f0c9 
Co-authored-by: Tim Bannister <[email protected]>
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz @sftim
Update content/en/blog/2022/SIG-Storage Spotlight.md
2daef40 
Co-authored-by: Tim Bannister <[email protected]>
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz @sftim
Update content/en/blog/2022/SIG-Storage Spotlight.md
d80d90e 
Co-authored-by: Tim Bannister <[email protected]>
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz @sftim
Update content/en/blog/2022/SIG-Storage Spotlight.md
444e5fe 
Co-authored-by: Tim Bannister <[email protected]>
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz @sftim
Update content/en/blog/2022/SIG-Storage Spotlight.md
adb689a 
Co-authored-by: Tim Bannister <[email protected]>
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz
Added author, small updates as per review
908c246 
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 18, 2022

Thank you @xing-yang, I have reflected your review in my last commit.

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 18, 2022

/assign @mrbobbytables

@sftim
Copy link
Contributor

sftim commented Jul 26, 2022

I just noticed the filename: SIG-Storage Spotlight.md. Could I get that changed to not contain a space, and be lowercase, ie: content/en/blog/2022/sig-storage-spotlight.md?

fsmunoz and others added 2 commits July 26, 2022 14:55
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Jul 26, 2022 •
edited
Loading

I just noticed the filename: SIG-Storage Spotlight.md. Could I get that changed to not contain a space, and be lowercase, ie: content/en/blog/2022/sig-storage-spotlight.md?

Done in last commit 3d3e8ba

@fsmunoz
Copy link
Contributor Author

fsmunoz commented Aug 16, 2022

@sftim can you approve this? I was under the impression that only @mrbobbytables could (since that's what the bot says), but it seems that anyone in the OWNERS file can.

@sftim
Copy link
Contributor

sftim commented Aug 17, 2022

Ideally, we'd publish this to this blog and to the main Kubernetes blog on the same day. If you'd like that @fsmunoz , please open a PR against k/website to mirror this; see kubernetes/website#35530 for an example.

BTW the front matter and filename would be different between the 2 sites; the rest of the article can usually be an exact copy.

@fsmunoz
Update publication date
4f59d18 
Signed-off-by: Frederico Muñoz <[email protected]>
@fsmunoz
Copy link
Contributor Author

fsmunoz commented Aug 17, 2022

@sftim Thank you! I have updated the publication date in the last commit. I have also replaced the content of the initial PR I had opened against the main website. I can change the filename but I am not sure to what kubernetes/website#35084

@sftim
Copy link
Contributor

sftim commented Aug 18, 2022

/hold
due to issue #281

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 18, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 18, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsmunoz, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 18, 2022
@sftim
Copy link
Contributor

sftim commented Aug 22, 2022

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 8561092 into kubernetes:master Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@xing-yang xing-yang xing-yang left review comments

Assignees

@mrbobbytables mrbobbytables

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
SIG Contribex Comms Status
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@fsmunoz @sftim @k8s-ci-robot @xing-yang @mrbobbytables