blog:bot helper CI Job #293

SubhasmitaSw · 2022-03-15T15:47:46Z

Reference #31919

k8s-ci-robot · 2022-03-15T15:47:54Z

Welcome @SubhasmitaSw!

It looks like this is your first PR to kubernetes/contributor-site 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/contributor-site has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

content/en/blog/2022/K8s Triage bot Helper CI Job_ ‘make update’.md

jberkus · 2022-03-15T19:46:36Z

content/en/blog/2022/K8s Triage bot Helper CI Job_ ‘make update’.md

+---
+layout: blog
+title: "K8s Triage bot Helper CI Job: ‘*make update*’"
+date: 2022-03-15


what's your actual target publication date?

The actual date stands at 2022-02-25, should it be changed?

This should be a date in the future. Ideally, co-ordinate that date with the k/website blog team (eg: talk to me) as well so that it goes out on a day when no k/website PRs are due.

content/en/blog/2022/K8s Triage bot Helper CI Job_ ‘make update’.md

jberkus · 2022-03-15T19:56:19Z

Hey, thanks for this blog post! It looks great and will be really helpful for devs on Windows.

However, there are a bunch of formatting issues with it. One is that your use of sub-heads is odd and I don't think will flow well for the reader. The second is the lack of descriptions for any images. Finally, you use several different forms of code blocking, some of which I don't think work, unless they're special Hugo codes I don't know about.

Happy to help you revise this.

SubhasmitaSw · 2022-03-26T19:24:57Z

Hey, thanks for this blog post! It looks great and will be really helpful for devs on Windows.

However, there are a bunch of formatting issues with it. One is that your use of sub-heads is odd and I don't think will flow well for the reader. The second is the lack of descriptions for any images. Finally, you use several different forms of code blocking, some of which I don't think work, unless they're special Hugo codes I don't know about.

Happy to help you revise this.

I used formatting from the HackMd to which rendering seems problematic for the Github markdown. I have rectified a large portion of the things and added a description to conceivably every picture. Thanks for suggesting improvements and apology for being late.

sftim

Here's some more feedback. I think this is a really valuable article to publish, so I hope you find these suggestions useful @SubhasmitaSw.

content/en/blog/2022/K8s Triage bot Helper CI Job_ ‘make update’.md

sftim · 2022-03-28T17:33:24Z

content/en/blog/2022/K8s Triage bot Helper CI Job_ ‘make update’.md

+---
+layout: blog
+title: "K8s Triage bot Helper CI Job: ‘*make update*’"
+date: 2022-03-15


This should be a date in the future. Ideally, co-ordinate that date with the k/website blog team (eg: talk to me) as well so that it goes out on a day when no k/website PRs are due.

content/en/blog/2022/K8s Triage bot Helper CI Job_ ‘make update’.md

jberkus

A few more formatting issues -- mostly inappropriate use of block quotes.

Also, I don't quite understand the flow of the blog around the solutions, see comment.

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

sftim

I'm afraid I still see lots of things to fix

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

sftim · 2022-03-30T21:36:00Z

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

+* **Short Term:** add a CI job that folks can trigger when they need it, that runs `make update` and provides a zip archive that they can be told to download. The archive includes all the files that changed as a result of running `make update`.
+*  **Long Term:** add a new Prow bot command that generates an additional commit on their PR.


You could make the text “Short Term” and “Long Term” be hyperlinks to the relevant headings.

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

sftim · 2022-03-30T21:41:04Z

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

+![artifacts directory](jenkins.png)
+
+Now, update the PR by adding the extracted files you downloaded. 
+


There's no heading or steps about using the long term solution. Folks might wonder where that has gone.

My guess is that the long term solution is still a work in progress and you can't use it yet? Whatever the story is, let's make that really clear.

I have an idea how to arrange this better, suggestion coming.

sftim · 2022-03-30T21:52:07Z

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

+### System info:
+
+| OS name | Version | System type |Memory| WSL |
+| ------- | ------- | ----------- | ---  | --- |
+|Windows 11 home|10.0.22000 Build 22000|x64-based|8.00 GB|Ubuntu-20.04 (v2)|


Is this needed? I'd omit it.

I agree, it doesn't fit entirely to the article's context.

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

jberkus

Looks good to me. Let's schedule it and merge it!

k8s-ci-robot · 2022-04-14T22:14:31Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkus, SubhasmitaSw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jberkus]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

SubhasmitaSw · 2022-04-17T12:40:17Z

Looks good to me. Let's schedule it and merge it!

Please let me know where we shall communicate the schedule date either on slack or here itself.

sftim · 2022-04-26T09:13:28Z

Try to avoid merging long before the scheduled date due to #281

Also, please don't pick a date that's close to the v1.24 Kubernetes release.

sftim

@SubhasmitaSw the filename: 2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md contains special characters. How about k8s-bot-helper-ci-job.md?

I also suggested a title that doesn't contain asterisks and suchlike.

sftim · 2022-04-26T09:16:01Z

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

+---
+layout: blog
+title: >-
+    "K8s Triage bot Helper CI Job: ‘*make update*’"


Suggested change

"K8s Triage bot Helper CI Job: ‘*make update*’"

Kubernetes Build Helper CI job: Run "make update" within CI

I was changing those, I accidentally deleted the last changes when my pc went down. I shall push them soon.

If you have that update available you could open a new PR to update it. I'm afraid that would have to be a brand new PR as this one already merged.

SubhasmitaSw · 2022-04-26T09:20:08Z

Try to avoid merging long before the scheduled date due to #281

Also, please don't pick a date that's close to the v1.24 Kubernetes release.

The suggested date by @jberkus is 26/4.

sftim · 2022-04-26T10:10:57Z

Publishing on 2022-04-26 would be fine for the Kubernetes blog team. Ideally, update kubernetes/website#31919 to match the text of this one as well, so we can get them both published close together.

jberkus · 2022-04-26T16:15:52Z

/lgtm

Let's publish now.

sftim · 2022-04-28T12:38:46Z

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md

+![Failed Test Cases](failing_test_cases.png)
+
+Consecutively, 
+
+![Failed Test Cases robot comment](k8s_ci_failed_tests.png)


BTW, I don't think these images are working in the published article.

I'm concerned about this too, what could be causing this? Maybe the file is moved to some location not containing the images

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2022

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 15, 2022

k8s-ci-robot requested review from jberkus and jeefy March 15, 2022 15:48

jberkus suggested changes Mar 15, 2022

View reviewed changes

SubhasmitaSw force-pushed the CIJobBlog branch from 110fbd5 to 312b852 Compare March 26, 2022 19:19

sftim reviewed Mar 28, 2022

View reviewed changes

SubhasmitaSw force-pushed the CIJobBlog branch 2 times, most recently from e41c8c8 to 2968d3f Compare March 29, 2022 18:32

jberkus suggested changes Mar 29, 2022

View reviewed changes

SubhasmitaSw force-pushed the CIJobBlog branch from 01f3cfc to 9c68de0 Compare March 30, 2022 16:17

sftim suggested changes Mar 30, 2022

View reviewed changes

sftim reviewed Mar 30, 2022

View reviewed changes

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md Outdated Show resolved Hide resolved

jberkus reviewed Mar 30, 2022

View reviewed changes

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md Outdated Show resolved Hide resolved

sftim reviewed Mar 31, 2022

View reviewed changes

.../2022/2022-03-15-k8s-triage-bot-helper-ci-job/K8s Triage bot Helper CI Job_ ‘make update’.md Outdated Show resolved Hide resolved

SubhasmitaSw force-pushed the CIJobBlog branch 2 times, most recently from f059ccb to a4ba2cf Compare April 1, 2022 06:26

blog:bot helper CI Job

be5fc68

SubhasmitaSw force-pushed the CIJobBlog branch from c945b9f to be5fc68 Compare April 14, 2022 16:52

jberkus approved these changes Apr 14, 2022

View reviewed changes

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2022

SubhasmitaSw force-pushed the CIJobBlog branch from 4ffe3d6 to be5fc68 Compare April 26, 2022 09:13

sftim suggested changes Apr 26, 2022

View reviewed changes

k8s-ci-robot assigned jberkus Apr 26, 2022

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2022

k8s-ci-robot merged commit 8c452f9 into kubernetes:master Apr 26, 2022

sftim mentioned this pull request Apr 26, 2022

Revise CI bot helper article #302

Merged

SubhasmitaSw mentioned this pull request Apr 27, 2022

CI Job Blog #303

Merged

sftim reviewed Apr 28, 2022

View reviewed changes

SubhasmitaSw mentioned this pull request Sep 15, 2022

REQUEST: New membership for @SubhasmitaSw kubernetes/org#3697

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

blog:bot helper CI Job #293

blog:bot helper CI Job #293

SubhasmitaSw commented Mar 15, 2022

k8s-ci-robot commented Mar 15, 2022

jberkus Mar 15, 2022

SubhasmitaSw Mar 26, 2022

sftim Mar 28, 2022

jberkus commented Mar 15, 2022

SubhasmitaSw commented Mar 26, 2022 •

edited

Loading

sftim left a comment

sftim Mar 28, 2022

jberkus left a comment

sftim left a comment

sftim Mar 30, 2022

sftim Mar 30, 2022

jberkus Mar 30, 2022

sftim Mar 30, 2022

SubhasmitaSw Apr 1, 2022

jberkus left a comment

k8s-ci-robot commented Apr 14, 2022

SubhasmitaSw commented Apr 17, 2022

sftim commented Apr 26, 2022

sftim left a comment

sftim Apr 26, 2022

SubhasmitaSw Apr 26, 2022

sftim Apr 27, 2022

SubhasmitaSw commented Apr 26, 2022

sftim commented Apr 26, 2022

jberkus commented Apr 26, 2022

sftim Apr 28, 2022

SubhasmitaSw Apr 28, 2022

		* Short Term: add a CI job that folks can trigger when they need it, that runs `make update` and provides a zip archive that they can be told to download. The archive includes all the files that changed as a result of running `make update`.
		* Long Term: add a new Prow bot command that generates an additional commit on their PR.

		![artifacts directory](jenkins.png)

		Now, update the PR by adding the extracted files you downloaded.

	"K8s Triage bot Helper CI Job: ‘make update’"
	Kubernetes Build Helper CI job: Run "make update" within CI

blog:bot helper CI Job #293

blog:bot helper CI Job #293

Conversation

SubhasmitaSw commented Mar 15, 2022

k8s-ci-robot commented Mar 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jberkus commented Mar 15, 2022

SubhasmitaSw commented Mar 26, 2022 • edited Loading

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jberkus left a comment

Choose a reason for hiding this comment

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jberkus left a comment

Choose a reason for hiding this comment

k8s-ci-robot commented Apr 14, 2022

SubhasmitaSw commented Apr 17, 2022

sftim commented Apr 26, 2022

sftim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SubhasmitaSw commented Apr 26, 2022

sftim commented Apr 26, 2022

jberkus commented Apr 26, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

SubhasmitaSw commented Mar 26, 2022 •

edited

Loading