Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SIG-windows-2022-annual-report #7173

Merged
merged 1 commit into from
Apr 7, 2023
Merged

SIG-windows-2022-annual-report #7173

merged 1 commit into from
Apr 7, 2023

Conversation

marosset
Copy link
Contributor

@marosset marosset commented Mar 6, 2023

Which issue(s) this PR fixes:

Fixes #7120

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: marosset

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/annual-reports Issues or PRs related to the annual reports sig/windows Categorizes an issue or PR as relevant to SIG Windows. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 6, 2023
@marosset marosset changed the title WIP: SIG-windows-2022-annual-report SIG-windows-2022-annual-report Mar 20, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 20, 2023
@marosset
Copy link
Contributor Author

@jsturtevant @jayunit100 @aravindhp @claudiubelu
This is ready for review. I'm sure I missed some stuff.

aravindhp
aravindhp reviewed Mar 20, 2023
View reviewed changes
Copy link
Contributor

@aravindhp aravindhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor not. LGTM otherwise.

sig-windows/annual-report-2022.md Outdated Show resolved Hide resolved
@marosset
Copy link
Contributor Author

Just a minor not. LGTM otherwise.

Thanks for taking a look.
I'll wait for a few more people to review and address feedback in bulk.

claudiubelu
claudiubelu reviewed Apr 6, 2023
View reviewed changes
sig-windows/annual-report-2022.md
@@ -24,86 +25,87 @@
- [1981 - Windows Privileged Container Support](https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/1981-windows-privileged-container-support) - v1.26
- [2802 - Identify Pod's OS during API Server admission](https://github.com/kubernetes/enhancements/tree/master/keps/sig-windows/2802-identify-windows-pods-apiserver-admission) - v1.25

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Node log viewer work count?

Also, we did start working on InPlace Pod Vertical Scaling support for Windows, but it did not merge yet (kubernetes/kubernetes#112599)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also had the Windows pod sandbox stats information KEP: kubernetes/enhancements#3439

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node log viewer was 2023 :D
I added a note about the 2371 work

sig-windows/annual-report-2022.md
-
-
- [HostProcess containers](https://github.com/kubernetes/enhancements/blob/master/keps/sig-windows/1981-windows-privileged-container-support/README.md) graduated to `stable` in v1.26
- Windows performance tests are not reported on the [k8s perf dashboard](https://perf-dash.k8s.io/#/?jobname=soak-tests-capz-windows-2019&metriccategoryname=E2E&metricname=CPUUsage)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guide for adding Windows nodes using kubeadm with flannel and calico CNIs? https://github.com/kubernetes-sigs/sig-windows-tools/blob/master/guides/guide-for-adding-windows-node.md

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prometheus Windows exporter for Kubernetes? prometheus-community/windows_exporter#864

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, let me add both of those!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you missing the commit with these? I don't seem them...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, i forgot to push :/
Should be there now!

@marosset marosset force-pushed the sig-windows-2022-annual-report branch from a0d8242 to eb0f0af Compare April 6, 2023 18:19
@marosset
SIG-windows-2022-annual-report
2a08fb6 
Signed-off-by: Mark Rossetti <[email protected]>
@marosset marosset force-pushed the sig-windows-2022-annual-report branch from eb0f0af to 2a08fb6 Compare April 6, 2023 21:02
@jsturtevant
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2023
@k8s-ci-robot k8s-ci-robot merged commit 7e0fbca into kubernetes:master Apr 7, 2023
@marosset marosset deleted the sig-windows-2022-annual-report branch April 7, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aravindhp aravindhp aravindhp left review comments

@claudiubelu claudiubelu claudiubelu left review comments

@jsturtevant jsturtevant jsturtevant left review comments

Assignees

@jsturtevant jsturtevant

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/annual-reports Issues or PRs related to the annual reports cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
[sig-windows] PR tracking
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2022 Annual Report: SIG Windows
5 participants
@marosset @k8s-ci-robot @jsturtevant @claudiubelu @aravindhp