-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2021 annual report for SIG instrumentation #6463
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: logicalhan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Operational tasks in [sig-governance.md]: | ||
|
||
- [ ] [README.md] reviewed for accuracy and updated if needed | ||
- [ ] [CONTRIBUTING.md] reviewed for accuracy and updated if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pending #6462
|
||
Operational tasks in [sig-governance.md]: | ||
|
||
- [ ] [README.md] reviewed for accuracy and updated if needed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I owe a small update which needs to be approved by steering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes: #6464
--> | ||
|
||
- Stable | ||
- [1209 - Metrics Stability](https://git.k8s.io/enhancements/...) - 1.21 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to fix links in this section
/retitle [WIP] 2021 annual report for SIG instrumentation Han can you move the file? It's technically the report for last year: https://github.com/kubernetes/community/blob/master/sig-instrumentation/annual-report-2021.md |
1. What areas and/or subprojects does your group need the most help with? | ||
Any areas with 2 or fewer OWNERs? (link to more details) | ||
|
||
- [kubernetes-sigs/custom-metrics-apiserver](https://github.com/kubernetes-sigs/custom-metrics-apiserver/blob/master/OWNERS) has 1 active approver |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove custom-metrics-apiserver and metrics-server from this list. I mistakenly considered someone inactive when they have actually been active.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on https://github.com/kubernetes/community/pull/6463/files/83a275c21cb7143055f26b7a813e1c7cd628503c#r806269581, would it make sense to add klog?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so, seriathius and pohly are pretty active on it.
Co-authored-by: Elana Hashman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM, couple small things
Co-authored-by: Elana Hashman <[email protected]>
Co-authored-by: Elana Hashman <[email protected]>
Co-authored-by: David Ashpole <[email protected]>
Co-authored-by: David Ashpole <[email protected]>
/lgtm |
This is the annual report for SIG Instrumentation (currently a WIP).