-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github-management: add docs for master to main migration #5609
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Non-blocking, but a few suggestions and follow up items :)
It may also be worth publishing this on k8s.dev so we can just link people something like: k8s.dev/rename
fd3deb8
to
de33b48
Compare
I'll review tomorrow, but I'm also fine if this merges before then; I can open a followup PR if I have specific concerns. |
@spiffxp I'm good with waiting until you have a chance to review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huge huge thanks for putting this together. I have a few questions but can't say I feel strongly about blocking on any of them vs refining, except for the "pre-rename" suggestion.
Check if any of the prowjobs (presubmits, postsubmits or periodics) | ||
explicitly mention the `master` branch. | ||
|
||
- [ ] If a prowjob triggers on the `master` branch (`branches` field |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with this as written but still think / hope someone could do this en-masse and save folks the trouble
of the prowjob), add the `main` branch to the list | ||
(see [kubernetes/test-infra#20665] for an example). | ||
|
||
- [ ] If a prowjob mentions the `master` branch in `base_ref`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here. I hope to eliminate the necessity of this step with updates to pod utils and bootstrap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope to eliminate the necessity of this step with updates to pod utils and bootstrap
just for the record, issues tracking updates to:
PR status contexts to the new job name but this has not been tested yet. | ||
This _may_ also impact testgrid history post-migration. | ||
|
||
- [ ] If a prowjob calls scripts or code in your repo that explicitly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer seeding this with a few recipes/snippets on how to update scripts to refer to the default branch instead of hard coding and requiring a change in lockstep.
I'll offer some when at a keyboard
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll offer some when at a keyboard
I'm going to leave this to you :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since I didn't get these in before your latest round of updates, I'm going to do this as followup
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#5619 to track
de33b48
to
521469b
Compare
This document is meant to be used by repos without too much traffic, if they wish to migrate the default branch from master to main.
521469b
to
198374d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Ref: kubernetes/org#2222
This document is meant to be used by repos without too much traffic,
if they wish to migrate the default branch from master to main.
/hold
for review
/assign @spiffxp @mrbobbytables @cblecker