Guide for monitoring tests run by CI - final push #5449
Conversation
|
Skipping CI for Draft Pull Request. |
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
the
sig/testing
RobertKielty
changed the title
RobertKielty
changed the title
|
/test all |
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
RobertKielty
force-pushed
the
triage-tests-2
branch
from
a7af02b to
377d527
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
Co-authored-by: Joyce Kung <[email protected]> Co-authored-by: Jorge Alarcon Ochoa <[email protected]>
RobertKielty
force-pushed
the
triage-tests-2
branch
from
377d527 to
e945c56
Compare
There was a problem hiding this comment.
Been meaning to look through the latest set of changes for a bit. Thanks for all your work so far @RobertKielty !
| results in a grid. TestGrid's back end components are open sourced and can be | ||
| viewed in the [TestGrid repo] The front-end code |
There was a problem hiding this comment.
nit: unsure which is the correct way, but back end vs front-end should be consistent (i.e. use a space for both or use a hyphen for both).
| **Note**: It is important that all SIGs periodically monitor their jobs and | ||
| tests. Furthermore, if jobs or tests are failing or flaking, then pull requests | ||
| will take a lot longer to be merged. For more information on how flaking tests | ||
| disrupt PR merging and how to eliminate them see [Flaky Tests] |
There was a problem hiding this comment.
| disrupt PR merging and how to eliminate them see [Flaky Tests] | |
| disrupt PR merging and how to eliminate them see [Flaky Tests]. |
|
|
||
| If your contributions involve code for past releases of kubernetes (e.g. | ||
| cherry-picks or backports), we recommend you periodically check on the | ||
| *blocking* and *informing* dashboards for [past releases] |
There was a problem hiding this comment.
| *blocking* and *informing* dashboards for [past releases] | |
| *blocking* and *informing* dashboards for [past releases]. |
k8s-ci-robot
added
the
do-not-merge/hold
There was a problem hiding this comment.
/approve
/hold
I think we're about at merge and iterate so I'm going to approve.
But I defer to @thejoycekung for the final say, who continues to raise valid suggestions. Remove hold when you're ready to lgtm and thanks for the thorough reviews!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RobertKielty, spiffxp The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
k8s-ci-robot
removed
the
size/L
Hi @thejoycekung, doing a follow-up of this PR, do you have more suggestions or this PR is ready to be merged? |
|
hey @ramrodo thanks for following up! I remember chatting with @RobertKielty about this a few weeks ago -- from what I can tell there are still a few unaddressed comments, but once those are fixed I'd love to push this through :) |
|
Looks like this got stuck. /lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
/label tide/merge-method-squash |
k8s-ci-robot
added
the
tide/merge-method-squash
Re-submission of the Test Monitoring Guide written by @alejandrox1
We will apply feedback as requested by @justaugustus here on the original PR
Origin thread on Slack
@spiffxp @thejoycekung @hasheddan @jeremyrickard @justaugustus