Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

italian version #3745

Closed
wants to merge 1 commit into from
Closed

italian version #3745

wants to merge 1 commit into from

Conversation

micheleberardi
Copy link
Member

translate README in italian

@k8s-ci-robot
Copy link
Contributor

Welcome @micheleberardi!

It looks like this is your first PR to kubernetes/community 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/community has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 29, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: micheleberardi
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: guineveresaenger

If they are not already assigned, you can assign the PR to them by writing /assign @guineveresaenger in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/contributor-guide Issues or PRs related to the contributor guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels May 29, 2019
@k8s-ci-robot
Copy link
Contributor

@micheleberardi: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-community-verify aae9818 link /test pull-community-verify

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nikhita
Copy link
Member

nikhita commented May 30, 2019

@micheleberardi you'll need to add this file to https://github.com/kubernetes/community/blob/master/hack/.spelling_failures, since looking for english spellings won't help here 😄

/cc @kubernetes/sig-docs-it-reviews

@tpepper
Copy link
Member

tpepper commented Jun 11, 2019

Can we get a second Italian speaker beyond the PR author to give it a proof read?

@mrbobbytables
Copy link
Member

I can give a few people a poke to follow-up.

/cc

@jnardiello
Copy link

jnardiello commented Jun 11, 2019

I'm having a look, I'm on it. Will provide feedback ASAP.

Copy link

@jnardiello jnardiello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really sorry but this translation has really many grammar/sentence mistakes. I would say most of the sentences or entire chapters are using words out of context. I don't mean to sound rude, but it really feels like it was done using Google Translate by someone who does not speak Italian. Overall it requires a lot of rework or (even better) an entirely new translation.

@micheleberardi
Copy link
Member Author

sorry, guys my bad I pushed the wrong file. i will close the PR and i will open a new one
sorry if I wasted your time and thanks for the support

@mrbobbytables
Copy link
Member

No worries @micheleberardi thanks again for taking a first pass at it!

@jnardiello
Copy link

@micheleberardi Let me know if I can help somehow, we can totally work on it together and I'd be happy to help!

@micheleberardi
Copy link
Member Author

@jnardiello Thanks so much for your amazing help and sorry for all the mess.
it was totally my fault, I uploaded the file that I translated with Google without to do the review.
In the future, before to push something I will contact you for any doubts.

@mrbobbytables
Copy link
Member

Just an FYI -- If you include [WIP] at the beginning of the title of the PR, it will place a hold on the PR and label it as do-not-merge/work-in-progress. It acts as a signal to other contributors that the the PR is intended as a work in process and not necessarily ready for review yet or in a more iterative state where large changes are expected. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants