Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apiserver-network-proxy to the cloud-provider-extraction-migration subproject #3598

Merged
merged 2 commits into from
Apr 17, 2019
Merged

Add apiserver-network-proxy to the cloud-provider-extraction-migration subproject #3598

merged 2 commits into from
Apr 17, 2019

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Apr 16, 2019

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 16, 2019
@k8s-ci-robot k8s-ci-robot added the sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. label Apr 16, 2019
@nikhita nikhita mentioned this pull request Apr 16, 2019
Closed
@andrewsykim
Copy link
Member

/lgtm

Thank you @nikhita!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@nikhita
Copy link
Member Author

nikhita commented Apr 16, 2019

/assign @cblecker
for approval

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2019
@nikhita
Copy link
Member Author

nikhita commented Apr 16, 2019

Updated to also include https://github.com/kubernetes/legacy-cloud-providers in this PR. Ref: kubernetes/org#719

@nikhita nikhita mentioned this pull request Apr 16, 2019
Closed
cheftako
cheftako approved these changes Apr 17, 2019
View reviewed changes
Copy link
Member

@cheftako cheftako left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 17, 2019
@cblecker
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, cheftako, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 85d3f39 into kubernetes:master Apr 17, 2019
@nikhita nikhita deleted the apiserver-network-proxy branch April 19, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheftako cheftako cheftako approved these changes

@andrewsykim andrewsykim Awaiting requested review from andrewsykim

@jdumars jdumars Awaiting requested review from jdumars

Assignees

@cheftako cheftako

@cblecker cblecker

@andrewsykim andrewsykim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nikhita @andrewsykim @cblecker @k8s-ci-robot @cheftako