Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admission Webhook Path to GA KEP #3157

Closed
wants to merge 1 commit into from

Conversation

mbohlool
Copy link
Contributor

@mbohlool mbohlool commented Jan 27, 2019

Enhancement proposal to promote Admission Webhooks to GA.

@deads2k @liggitt @sttts @erictune @caesarxuchao @roycaihw @fedebongio @lavalamp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. kind/design Categorizes issue or PR as related to design. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Jan 27, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mbohlool
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lavalamp

If they are not already assigned, you can assign the PR to them by writing /assign @lavalamp in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mbohlool
Copy link
Contributor Author

/sig api-machinery

@cblecker
Copy link
Member

/hold

I think this is supposed to be a kep in k/enhancements.

/cc @kubernetes/kep-maintainers

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 27, 2019
@justaugustus
Copy link
Member

Yes, this needs to be migrated over to k/enhancements.

@deads2k
Copy link
Contributor

deads2k commented Jan 28, 2019

I think that any plan to graduate to GA needs to address the existent problems that have been identified around admission plugin ordering. Notably kubernetes/kubernetes#64333 which prevents mutating admission plugins from manipulating pods.

/hold

@mbohlool
Copy link
Contributor Author

closing in favor of kubernetes/enhancements#736

(have not addressed any comments on this document yet, will do).

@mbohlool mbohlool closed this Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/design Categorizes issue or PR as related to design. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants