Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Links Fix for #2696 #2968

Merged
merged 1 commit into from
Nov 25, 2018
Merged

Broken Links Fix for #2696 #2968

merged 1 commit into from
Nov 25, 2018

Conversation

ramnar
Copy link
Contributor

@ramnar ramnar commented Nov 24, 2018

FILE: ./keps/sig-cloud-provider/providers/0020-cloud-provider-alibaba-cloud.md

[✖] https://github.com/kubernetes/community/blob/master/keps/sig-cloud-provider/0003-testgrid-conformance-e2e.md
→ Status: 404

FILE: ./keps/sig-cloud-provider/providers/0004-cloud-provider-template.md
[✖] https://github.com/kubernetes/community/blob/master/keps/sig-cloud-provider/0003-testgrid-conformance-e2e.md
→ Status: 404
[✖] https://github.com/kubernetes/community/blob/master/keps/sig-cloud-provider/0004-cloud-provider-documentation.md
→ Status: 404

FILE: ./sig-docs/migrated-from-wiki/roadmap-docs.md
[✖] https://git.k8s.io/kubernetes/examples/guidelines.md → Status: 404

FILE: ./sig-cluster-lifecycle/charter.md
[✖] ../sig-apimachinery → Status: 400 Error: ENOENT: no such file or
directory, access
'/home/jorge/src/kubernetes/community/sig-apimachinery'

FILE: ./keps/sig-cloud-provider/providers/0020-cloud-provider-alibaba-cloud.md

[✖] https://github.com/kubernetes/community/blob/master/keps/sig-cloud-provider/0003-testgrid-conformance-e2e.md
→ Status: 404

FILE: ./keps/sig-cloud-provider/providers/0004-cloud-provider-template.md
[✖] https://github.com/kubernetes/community/blob/master/keps/sig-cloud-provider/0003-testgrid-conformance-e2e.md
→ Status: 404
[✖] https://github.com/kubernetes/community/blob/master/keps/sig-cloud-provider/0004-cloud-provider-documentation.md
→ Status: 404

FILE: ./sig-docs/migrated-from-wiki/roadmap-docs.md
[✖] https://git.k8s.io/kubernetes/examples/guidelines.md → Status: 404

FILE: ./sig-cluster-lifecycle/charter.md
[✖] ../sig-apimachinery → Status: 400 Error: ENOENT: no such file or
directory, access
'/home/jorge/src/kubernetes/community/sig-apimachinery'
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/kep sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @ramnar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jagosan
Copy link
Contributor

jagosan commented Nov 24, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 24, 2018
Copy link
Member

@cblecker cblecker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 25, 2018
@k8s-ci-robot k8s-ci-robot merged commit 3b3f730 into kubernetes:master Nov 25, 2018
justaugustus pushed a commit to justaugustus/community that referenced this pull request Dec 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants