Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #2957

Closed
wants to merge 1 commit into from
Closed

Update README.md #2957

wants to merge 1 commit into from

Conversation

ramnar
Copy link
Contributor

@ramnar ramnar commented Nov 21, 2018

Corrected the grammar from 'can always use improvement' to 'can always be improved'

Corrected the grammar from 'can always use improvement' to 'can always be improved'
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 21, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @ramnar. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: parispittman

If they are not already assigned, you can assign the PR to them by writing /assign @parispittman in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/contributor-guide Issues or PRs related to the contributor guide sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Nov 21, 2018
@@ -74,7 +74,7 @@ The Kubernetes team scans Stack Overflow on a regular basis and will try to ensu

## Find something to work on

Help is always welcome! For example, documentation (like the text you are reading now) can always use improvement.
Help is always welcome! For example, documentation (like the text you are reading now) can always be improved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, but it seems both are right in grammar.

Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessary to change.

@nikhita
Copy link
Member

nikhita commented Nov 21, 2018

I agree with @idealhack and @idvoretskyi - the original grammar is correct as well and it's not necessary to make the change.

@ramnar If you are looking to get started with contributing, I'd suggest you take a tackle a few links in #2696. This issues mentions links that lead to a 404 right now. It's a good way to understand our PR review process and also help us in correcting some of the links! :)

Closing this since it's not needed per se. Thanks for your PR though.
/close

@k8s-ci-robot
Copy link
Contributor

@nikhita: Closed this PR.

In response to this:

I agree with @idealhack and @idvoretskyi - the original grammar is correct as well and it's not necessary to make the change.

@ramnar If you are looking to get started with contributing, I'd suggest you take a tackle a few links in #2696. This issues mentions links that lead to a 404 right now. It's a good way to understand our PR review process and also help us in correcting some of the links! :)

Closing this since it's not needed per se. Thanks for your PR though.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/contributor-guide Issues or PRs related to the contributor guide cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants