-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #2957
Update README.md #2957
Conversation
Corrected the grammar from 'can always use improvement' to 'can always be improved'
Hi @ramnar. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: If they are not already assigned, you can assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@@ -74,7 +74,7 @@ The Kubernetes team scans Stack Overflow on a regular basis and will try to ensu | |||
|
|||
## Find something to work on | |||
|
|||
Help is always welcome! For example, documentation (like the text you are reading now) can always use improvement. | |||
Help is always welcome! For example, documentation (like the text you are reading now) can always be improved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, but it seems both are right in grammar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not necessary to change.
I agree with @idealhack and @idvoretskyi - the original grammar is correct as well and it's not necessary to make the change. @ramnar If you are looking to get started with contributing, I'd suggest you take a tackle a few links in #2696. This issues mentions links that lead to a 404 right now. It's a good way to understand our PR review process and also help us in correcting some of the links! :) Closing this since it's not needed per se. Thanks for your PR though. |
@nikhita: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Corrected the grammar from 'can always use improvement' to 'can always be improved'