Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update community-meeting.md #2734

Merged
merged 1 commit into from
Oct 1, 2018
Merged

Update community-meeting.md #2734

merged 1 commit into from
Oct 1, 2018

Conversation

iamrare
Copy link
Contributor

@iamrare iamrare commented Oct 1, 2018

just a typo, was 2014-1016
should be 2014-2016
as mentioned by @nikhita here: #2696 (comment)

Update community-meeting.md
453fd00 
just a typo, was `2014-1016`
should be `2014-2016`
as mentioned by @nikhita here: kubernetes#2696 (comment)
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 1, 2018
@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. labels Oct 1, 2018
@nikhita
Copy link
Member

nikhita commented Oct 1, 2018

@mohammedfakhar Thanks for your first contribution! 🎉

/ok-to-test
/lgtm

/assign @castrojo
for approval

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2018
@iamrare
Copy link
Contributor Author

iamrare commented Oct 1, 2018

thank you!
the community is so kind and welcoming. reviews are very fast. I will encourage other people to contribute too. thank you again.

idvoretskyi
idvoretskyi approved these changes Oct 1, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: idvoretskyi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 1, 2018
@k8s-ci-robot k8s-ci-robot merged commit 633c4c1 into kubernetes:master Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@castrojo castrojo Awaiting requested review from castrojo

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@castrojo castrojo

@nikhita nikhita

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@iamrare @nikhita @k8s-ci-robot @idvoretskyi @castrojo