Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some audio/visual recommendations #2504

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Add some audio/visual recommendations #2504

merged 1 commit into from
Aug 30, 2018

Conversation

castrojo
Copy link
Member

@castrojo castrojo commented Aug 9, 2018

I had these as a blog post, which I've adapted for general use and might be useful to folks.

/sig contributor-experience

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/community-management labels Aug 9, 2018
@spiffxp
Copy link
Member

spiffxp commented Aug 9, 2018 

W0809 14:54:36.549] communication/zoom-guidelines.md:69:313: "occurence" is a misspelling of "occurrence"
W0809 14:54:36.549] communication/zoom-guidelines.md:72:185: "concensus" is a misspelling of "consensus"

@jdumars
Copy link
Member

jdumars commented Aug 27, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 27, 2018
jdumars
jdumars approved these changes Aug 27, 2018
View reviewed changes
Copy link
Member

@jdumars jdumars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TO DO: Add "screen sharing guidelines and recommendations"

@castrojo
Copy link
Member Author

I filed this for a followup: #2599

idvoretskyi
idvoretskyi approved these changes Aug 30, 2018
View reviewed changes
Copy link
Member

@idvoretskyi idvoretskyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@idvoretskyi
Copy link
Member

@castrojo great!

@jdumars
Copy link
Member

jdumars commented Aug 30, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jdumars

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 92a47fa into kubernetes:master Aug 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdumars jdumars jdumars approved these changes

@idvoretskyi idvoretskyi idvoretskyi approved these changes

@parispittman parispittman Awaiting requested review from parispittman

Assignees

@idvoretskyi idvoretskyi

@jdumars jdumars

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/community-management cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@castrojo @spiffxp @jdumars @idvoretskyi @k8s-ci-robot