KEP: Add kubectl plugin manager (krew) #2340

lbb · 2018-07-03T20:26:44Z

No description provided.

k8s-ci-robot · 2018-07-03T20:26:55Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: idvoretskyi

Assign the PR to them by writing /assign @idvoretskyi in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

keps/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

duglin · 2018-07-03T20:51:44Z

keps/sig-cli/0014-krew.md

+
+The kubectl plugin system allows users to extend kubectl by placing extension
+executables in a plugin directory. This allows new subcommands and subcommand
+trees to be added in the kubectl CLI interface under `kubectl plugin <NAME>`.


let's really see if we can remove the "plugin" word from the cmd line - that's a pretty big UX issue

save the "plugin" word for managing plugins

That makes sense. I think that issue is out of scope for this KEP and is related to https://github.com/kubernetes/community/blob/a6dcf8678b5c3febaacf079b28174b4a2cbd88e2/contributors/design-proposals/cli/kubectl-extension.md

idealhack · 2018-07-04T07:45:28Z

/ok-to-test

soltysh

/hold
As part of 1.12 release plugins are undergoing significant refactoring, due to this factor I'd prefer to hold this proposal until after that initial effort is implemented. Additionally, from the several discussion we've had during past several months I haven't heard of anyone bringing the topic of managing plugins to the table for sig-cli. Moreover, each time we discussed plugins we clearly stated we don't want to manage them, at least not yet.
Before proceeding this further I'd like to see this topic being presented during one of sig-cli meetings and most importantly take into account planned changes to the plugins mechanism.

soltysh · 2018-07-04T13:07:29Z

keps/sig-cli/0014-krew.md

+#### Capabilities
+
+Note: This proposal has already been implemented in
+`github.com/GoogleContainerTools/krew` as a proof of concept.


Does not exist.

The repository is now publicly accessible 😄
Same URL: https://github.com/GoogleContainerTools/krew

k8s-ci-robot · 2018-07-20T22:57:01Z

@lbb: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh · 2018-08-24T13:58:53Z

@lbb now that we can plugins up and ready can you update the current proposal and this can land?

errordeveloper · 2018-08-31T09:34:31Z

@soltysh are you referring to https://github.com/kubernetes/community/blob/master/keps/sig-cli/0024-kubectl-plugins.md? I'm finding it difficult to track the status of that KEP.

ahmetb · 2018-08-31T18:01:40Z

I'm tempted to hold off on this KEP until there is a kubectl release with the new plugin model shipped:

The plugin model change breaks krew and renders it unusable. We need to refactor krew and its plugin manifest to install plugins to somewhere in PATH.
We don't have enough plugins to understand if the manifest, installation system and the upgrade model is sufficient and satisfies users and packaging across multiple platforms (esp. Windows). We are working on getting more plugin devs to adopt the krew packaging format.

After we feel confident, we should come back to make progress on the KEP.

juanvallejo · 2018-08-31T18:23:28Z

@errordeveloper

are you referring to https://github.com/kubernetes/community/blob/master/keps/sig-cli/0024-kubectl-plugins.md? I'm finding it difficult to track the status of that KEP.

The implementation for that KEP will be available as part of the 1.12 release

soltysh · 2018-09-25T17:00:28Z

Now that we have the plugin implementation ready as part of 1.12 release, this can continue.
/hold cancel

ahmetb · 2018-09-25T17:59:05Z

Small status update: we're still working on porting krew to the new plugin model introduced in 1.12. There are quite a lot of blocking changes, but we're close to releasing a krew v0.2 that's testable.

justaugustus · 2018-10-13T03:24:01Z

/kind kep

mattfarina · 2018-10-31T19:29:12Z

keps/sig-cli/0014-krew.md

+editor: lbb
+creation-date: 2018-07-03
+last-updated: yyyy-mm-dd
+status: provisional


Given the discussion on the issue it sounds like this KEP is in the implementable status. See https://github.com/kubernetes/community/blob/master/keps/0001-kubernetes-enhancement-proposal-process.md#kep-workflow

mattfarina · 2018-10-31T19:32:46Z

keps/sig-cli/0014-krew.md

+### Scenarios (standalone only)
+
+* User wants to install krew. They can run one `curl` command to install the
+  plugin manager, the plugin manager should then be able to function properly.


Will the install scenario be the case or will it be apart of kubectl as earlier stated? Should this define the process for the proof of concept or what's going to be part of the toolchain?

mattfarina · 2018-10-31T19:33:28Z

keps/sig-cli/0014-krew.md

@@ -0,0 +1,237 @@
+---
+kep-number: 14
+title: Krew


The name confused me when I first looked at this. I understand that krew is the name of the proof of concept. Should the title be more expressive of the purpose?

mattfarina · 2018-10-31T19:37:50Z

keps/sig-cli/0014-krew.md

+  plugin manager to discover and manage plugins.
+* Developer wants to update their plugin and make those changes public.
+  They create a new PR against the index repository updating their plugin meta
+  description file. 


How do developers pin or otherwise deal with versions of plugins?

mattfarina · 2018-10-31T19:41:11Z

@soltysh Where is this at in terms of its lifecycle? How far is it from being merged where updates can be via other PRs? Is krew going to be moved under k8s control?

justaugustus · 2018-11-20T04:43:51Z

REMINDER: KEPs are moving to k/enhancements on November 30. Please attempt to merge this KEP before then to signal consensus.
For more details on this change, review this thread.

Any questions regarding this move should be directed to that thread and not asked on GitHub.

justaugustus · 2018-12-01T08:05:05Z

KEPs have moved to k/enhancements.
This PR will be closed and any additional changes to this KEP should be submitted to k/enhancements.
For more details on this change, review this thread.

Any questions regarding this move should be directed to that thread and not asked on GitHub.
/close

k8s-ci-robot · 2018-12-01T08:05:06Z

@justaugustus: Closed this PR.

In response to this:

KEPs have moved to k/enhancements.
This PR will be closed and any additional changes to this KEP should be submitted to k/enhancements.
For more details on this change, review this thread.

Any questions regarding this move should be directed to that thread and not asked on GitHub.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhiller · 2019-06-14T10:56:36Z

@lbb I understand this PR should have been moved to k/enhancements. When will this happen?

lbb added 2 commits July 3, 2018 12:25

Update NEXT_KEP_NUMBER

1c62c94

Create 0014-krew.md

1e94f14

k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 3, 2018

k8s-ci-robot requested review from idvoretskyi and jdumars July 3, 2018 20:26

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Jul 3, 2018

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 3, 2018

duglin reviewed Jul 3, 2018

View reviewed changes

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2018

soltysh suggested changes Jul 4, 2018

View reviewed changes

k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2018

This was referenced Jul 12, 2018

KEP #14(dup): Add kubectl plugin manager (krew) kubernetes-retired/architecture-tracking#38

Closed

KEP #15(dup): Add kubectl plugin manager (krew) KEP kubernetes-retired/architecture-tracking#39

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2018

castrojo mentioned this pull request Sep 20, 2018

404 report for k/community #2696

Closed

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 25, 2018

k8s-ci-robot added the kind/kep label Oct 13, 2018

thockin changed the title ~~Add kubectl plugin manager (krew) KEP~~ KEP: Add kubectl plugin manager (krew) Oct 18, 2018

mattfarina reviewed Oct 31, 2018

View reviewed changes

m1kola mentioned this pull request Nov 15, 2018

kryp as a kubectl plugin monzo/kontrast#12

Closed

k8s-ci-robot closed this Dec 1, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

KEP: Add kubectl plugin manager (krew) #2340

KEP: Add kubectl plugin manager (krew) #2340

lbb commented Jul 3, 2018

k8s-ci-robot commented Jul 3, 2018

duglin Jul 3, 2018

duglin Jul 3, 2018

lbb Jul 3, 2018

idealhack commented Jul 4, 2018

soltysh left a comment

soltysh Jul 4, 2018

lbb Jul 16, 2018

k8s-ci-robot commented Jul 20, 2018

soltysh commented Aug 24, 2018

errordeveloper commented Aug 31, 2018 •

edited

Loading

ahmetb commented Aug 31, 2018

juanvallejo commented Aug 31, 2018

soltysh commented Sep 25, 2018

ahmetb commented Sep 25, 2018

justaugustus commented Oct 13, 2018

mattfarina Oct 31, 2018

mattfarina Oct 31, 2018

mattfarina Oct 31, 2018

mattfarina Oct 31, 2018

mattfarina commented Oct 31, 2018

justaugustus commented Nov 20, 2018

justaugustus commented Dec 1, 2018

k8s-ci-robot commented Dec 1, 2018

dhiller commented Jun 14, 2019

KEP: Add kubectl plugin manager (krew) #2340

KEP: Add kubectl plugin manager (krew) #2340

Conversation

lbb commented Jul 3, 2018

k8s-ci-robot commented Jul 3, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

idealhack commented Jul 4, 2018

soltysh left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k8s-ci-robot commented Jul 20, 2018

soltysh commented Aug 24, 2018

errordeveloper commented Aug 31, 2018 • edited Loading

ahmetb commented Aug 31, 2018

juanvallejo commented Aug 31, 2018

soltysh commented Sep 25, 2018

ahmetb commented Sep 25, 2018

justaugustus commented Oct 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mattfarina commented Oct 31, 2018

justaugustus commented Nov 20, 2018

justaugustus commented Dec 1, 2018

k8s-ci-robot commented Dec 1, 2018

dhiller commented Jun 14, 2019

errordeveloper commented Aug 31, 2018 •

edited

Loading