-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Logging Conventions doc with structured logging #5593
Comments
@ehashman: Please ensure the request meets the requirements listed here. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@ehashman: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/sig instrumentation |
Hey can i take this up? |
/milestone v1.21 @iraj465 go for it! |
@ehashman: You must be a member of the kubernetes/community-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Community Milestone Maintainers and have them propose you as an additional delegate for this responsibility. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign |
/close Fixed in #5624 |
@ehashman: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
File to update: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md
Currently this references non-structured log functions. Following the structured log migration guide, we should update this to use structured logging equivalents instead.
/sig instrumentaton
/help
The text was updated successfully, but these errors were encountered: