Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Logging Conventions doc with structured logging #5593

Closed
ehashman opened this issue Mar 4, 2021 · 9 comments
Closed

Update Logging Conventions doc with structured logging #5593

ehashman opened this issue Mar 4, 2021 · 9 comments
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation.

Comments

@ehashman
Copy link
Member

ehashman commented Mar 4, 2021

File to update: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md

Currently this references non-structured log functions. Following the structured log migration guide, we should update this to use structured logging equivalents instead.

/sig instrumentaton
/help

@k8s-ci-robot
Copy link
Contributor

@ehashman:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

File to update: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md

Currently this references non-structured log functions. Following the structured log migration guide, we should update this to use structured logging equivalents instead.

/sig instrumentaton
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

@ehashman: The label(s) sig/instrumentaton cannot be applied, because the repository doesn't have them.

In response to this:

File to update: https://github.com/kubernetes/community/blob/master/contributors/devel/sig-instrumentation/logging.md

Currently this references non-structured log functions. Following the structured log migration guide, we should update this to use structured logging equivalents instead.

/sig instrumentaton
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 4, 2021
@ehashman
Copy link
Member Author

ehashman commented Mar 4, 2021

/sig instrumentation
/kind documentation

@k8s-ci-robot k8s-ci-robot added sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. kind/documentation Categorizes issue or PR as related to documentation. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 4, 2021
@iraj465
Copy link
Contributor

iraj465 commented Mar 8, 2021

Hey can i take this up?

@ehashman
Copy link
Member Author

ehashman commented Mar 8, 2021

/milestone v1.21

@iraj465 go for it!

@k8s-ci-robot
Copy link
Contributor

@ehashman: You must be a member of the kubernetes/community-milestone-maintainers GitHub team to set the milestone. If you believe you should be able to issue the /milestone command, please contact your Community Milestone Maintainers and have them propose you as an additional delegate for this responsibility.

In response to this:

/milestone v1.21

@iraj465 go for it!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@iraj465
Copy link
Contributor

iraj465 commented Mar 10, 2021

/assign

@ehashman
Copy link
Member Author

/close

Fixed in #5624

@k8s-ci-robot
Copy link
Contributor

@ehashman: Closing this issue.

In response to this:

/close

Fixed in #5624

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation.
Projects
None yet
Development

No branches or pull requests

3 participants