Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to your timezone link shows the wrong time #4961

Closed
lizhuqi opened this issue Jul 14, 2020 · 4 comments · Fixed by #4983
Closed

Convert to your timezone link shows the wrong time #4961

lizhuqi opened this issue Jul 14, 2020 · 4 comments · Fixed by #4983
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Milestone
v1.19

Comments

@lizhuqi
Copy link

lizhuqi commented Jul 14, 2020

I clicked the "Convert to your timezone" link in README.md doc, it shows 10:30AM for our local time(PST). However the right PST time shall be 9:30AM so I think the time converter is not converting the time correctly.
TimeConverter
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jul 14, 2020
@lizhuqi
Copy link
Author

lizhuqi commented Jul 14, 2020

@k8s-ci-robot
/sig windows

@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 14, 2020
@mrbobbytables
Copy link
Member

It looks like because the timezone is set for Eastern Standard Time when it is currently Eastern Daylight Time. This should be set to Eastern Time (ET) instead of Eastern Standard Time similar to how it is done for ContribEx:

community/sigs.yaml

Lines 1090 to 1093 in 421c198

- description: Regular SIG Meeting
day: Wednesday
time: "9:30"
tz: PT (Pacific Time)

That will avoid it falling out of sync when daylight savings time is in effect.

After updating the tz field for sig windows in sigs.yaml to be ET (Eastern Time) if you run make it should propagate the change to all other locations.

/help
/good-first-issue

@k8s-ci-robot
Copy link
Contributor

@mrbobbytables:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

It looks like because the timezone is set for Eastern Standard Time when it is currently Eastern Daylight Time. This should be set to Eastern Time (ET) instead of Eastern Standard Time similar to how it is done for ContribEx:

community/sigs.yaml

Lines 1090 to 1093 in 421c198

- description: Regular SIG Meeting
day: Wednesday
time: "9:30"
tz: PT (Pacific Time)

That will avoid it falling out of sync when daylight savings time is in effect.

After updating the tz field for sig windows in sigs.yaml to be ET (Eastern Time) if you run make it should propagate the change to all other locations.

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 14, 2020
@NagarajGoud
Copy link

NagarajGoud commented Jul 15, 2020 •
edited
Loading

I think i can start my journey with this. Can I take this up.

@championshuttler championshuttler mentioned this issue Jul 22, 2020
Merged
@mrbobbytables mrbobbytables added this to the v1.19 milestone Aug 18, 2020
@lizhuqi lizhuqi mentioned this issue Dec 14, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/windows Categorizes an issue or PR as relevant to SIG Windows.
Projects
None yet
Milestone
v1.19
Development

Successfully merging a pull request may close this issue.

Fix the timezone for EST championshuttler/community
4 participants
@mrbobbytables @lizhuqi @k8s-ci-robot @NagarajGoud