Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestNamespaceAuthorization link broken under Testing Conventions #266

Closed
darshanramu opened this issue Jan 12, 2017 · 3 comments
Closed

TestNamespaceAuthorization link broken under Testing Conventions #266

darshanramu opened this issue Jan 12, 2017 · 3 comments
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.

Comments

@darshanramu
Copy link

The following link is not found under Testing Conventions.
TestNamespaceAuthorization -> https://github.com/kubernetes/community/blob/master/test/integration/auth/auth_test.go
@pmorie
Copy link
Member

pmorie commented Feb 11, 2017

It's inherently fragile to link to specific code constructs in this manner -- we should either link to a specific git commit (ugly) or embed an example directly in the documentation.

This is another case for a link checker #359

@k8s-github-robot
Copy link

@darshanramu
There are no sig labels on this issue. Please add a sig label by:

  1. mentioning a sig: @kubernetes/sig-<group-name>-<group-suffix>
    e.g., @kubernetes/sig-contributor-experience-<group-suffix> to notify the contributor experience sig, OR

  2. specifying the label manually: /sig <label>
    e.g., /sig scalability to apply the sig/scalability label

Note: Method 1 will trigger an email to the group. You can find the group list here and label list here.
The <group-suffix> in the method 1 has to be replaced with one of these: bugs, feature-requests, pr-reviews, test-failures, proposals

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Aug 15, 2017
@cblecker
Copy link
Member

This is fixed.

danehans pushed a commit to danehans/community that referenced this issue Jul 18, 2023
@ayj @istio-testing
add myself to networking maintainers (kubernetes#266)
f66e564 
Ownership of the galley configuration machinery is being transfered to
the top-level network maintainers as part of the Config and UX WG
merger (see [1]). In anticipation of deleting the istio config
maintainers group I'm adding myself to the general networking group to
maintain parity with the previous ownership.

[1] - https://docs.google.com/document/d/1B6FlFMaaqsqOaEFb-6U5VR94d3eUrc4WbqxJrdeblf8/edit#
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pmorie @cblecker @k8s-github-robot @darshanramu