Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to developer guide from the contributor guide #1632

Closed
castrojo opened this issue Jan 19, 2018 · 25 comments
Closed

Link to developer guide from the contributor guide #1632

castrojo opened this issue Jan 19, 2018 · 25 comments
Assignees
@castrojo
Labels
area/contributor-guide Issues or PRs related to the contributor guide good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Milestone
May

Comments

@castrojo
Copy link
Member

We need to sync with RyanJ or someone else working on the developer guide and at least link to whatever they have so far as a starting point

/sig contributor-experience
/area contributor-guide
@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. area/contributor-guide Issues or PRs related to the contributor guide and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jan 19, 2018
@castrojo castrojo self-assigned this Jan 19, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2018
@castrojo
Copy link
Member Author

/remove-lifecycle stale
/help

@k8s-ci-robot k8s-ci-robot added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 24, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 23, 2018
@nikhita
Copy link
Member

nikhita commented Aug 10, 2018

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 10, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 8, 2018
@nikhita
Copy link
Member

nikhita commented Nov 11, 2018

/remove-help
Removing the help-wanted label on this. Please re-add it again if this issue is still valid for a new-ish contributor.

/cc @ryanj

@k8s-ci-robot k8s-ci-robot removed the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 11, 2018
@idealhack
Copy link
Member

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2018
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 10, 2019
@nikhita
Copy link
Member

nikhita commented Feb 24, 2019

@castrojo I'm trying to understand what this issue better -- does this mean just adding a link to the developer guide from the contributor guide or hashing out some more things? If its the former, we could add back the good-first-issue label.

The developer guide has also gone through a major overhaul (thanks to @eduartua!).

@parispittman
Copy link
Contributor

@nikhita - pretty sure it's just a link to the main devrel readme when its ready

@nikhita
Copy link
Member

nikhita commented Feb 25, 2019

when its ready

@parispittman Thanks. Do you think we can link it even today? What does ready mean here? :)

@mrbobbytables
Copy link
Member

mrbobbytables commented Mar 18, 2019 •
edited
Loading

I think this is done? This section links to the root of devel - https://github.com/kubernetes/community/tree/master/contributors/guide#setting-up-your-development-environment

We could potentially be more explicit about linking to devel -- like linking to the readme directly the root makes it easier to browse. ¯\(ツ)/¯

@nikhita
Copy link
Member

nikhita commented Mar 18, 2019

We could potentially be more explicit about linking to devel -- like linking to the readme directly the root makes it easier to browse. ¯(ツ)/¯

SGTM. Let's close the issue once this is done. If anything else is needed, let's create follow-up issues with more details.

Adding the good first issue label back.

/good-first-issue

For anyone who takes this up -- the link here should point to https://github.com/kubernetes/community/blob/master/contributors/devel/README.md#setting-up-your-dev-environment-coding-and-debugging instead.

@k8s-ci-robot
Copy link
Contributor

@nikhita:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

We could potentially be more explicit about linking to devel -- like linking to the readme directly the root makes it easier to browse. ¯(ツ)/¯

SGTM. Let's close the issue once this is done. If anything else is needed, let's create follow-up issues with more details.

Adding the good first issue label back.

/good-first-issue

For anyone who takes this up -- the link here should point to https://github.com/kubernetes/community/blob/master/contributors/devel/README.md#setting-up-your-dev-environment-coding-and-debugging instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 18, 2019
@nikhita
Copy link
Member

nikhita commented Mar 18, 2019

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 18, 2019
@nikhita
Copy link
Member

nikhita commented Mar 18, 2019

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Mar 18, 2019
@nikhita
Copy link
Member

nikhita commented Mar 18, 2019

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 18, 2019
@castrojo
Copy link
Member Author

/milestone May

@k8s-ci-robot k8s-ci-robot added this to the May milestone Mar 20, 2019
@thecrudge
Copy link
Contributor

#3574

And I have signed the CLA, I just didnt setup my email smh

@thecrudge thecrudge mentioned this issue Apr 11, 2019
Merged
@thecrudge
Copy link
Contributor

thecrudge commented Apr 11, 2019 •
edited
Loading

/resolved :) after a year long sweep into the darkest corner

@thecrudge
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@thecrudge: You can't close an active issue/PR unless you authored it or you are a collaborator.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thecrudge
Copy link
Contributor

@castrojo @nikhita @parispittman @idealhack ^^^^^

@idealhack
Copy link
Member

@thecrudge thank you!

/close

@k8s-ci-robot
Copy link
Contributor

@idealhack: Closing this issue.

In response to this:

@thecrudge thank you!

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@castrojo castrojo

Labels
area/contributor-guide Issues or PRs related to the contributor guide good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience.
Projects
None yet
Milestone
May
Development

No branches or pull requests
8 participants
@idealhack @castrojo @parispittman @mrbobbytables @nikhita @k8s-ci-robot @fejta-bot @thecrudge