Skip to content

Commit

Permalink
Add emeritus to owners guidelines
Browse files Browse the repository at this point in the history
  • Loading branch information
Bob Killen committed Apr 22, 2019
1 parent 009a49c commit 1c9debd
Showing 1 changed file with 33 additions and 2 deletions.
35 changes: 33 additions & 2 deletions contributors/guide/owners.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ inspired [GitHub's CODEOWNERS files](https://help.github.com/articles/about-code
The velocity of a project that uses code review is limited by the number of people capable of
reviewing code. The quality of a person's code review is limited by their familiarity with the code
under review. Our goal is to address both of these concerns through the prudent use and maintenance
of OWNERS files
of OWNERS files.

## OWNERS spec

Expand Down Expand Up @@ -86,6 +86,36 @@ Instead, set a `.*` key inside `filters` (as shown in the previous example).
**WARNING**: The `approve` plugin [does not currently respect `filters`][test-infra-7690].
Until that is fixed, `filters` should only be used for the `labels` key (as shown in the above example).


#### Emeritus

It is inevitable, but there are times when someone may shift focuses, change jobs or step away from
a specific area in the project for a time. These people may be domain experts over certain areas
of the codebase, but can no longer dedicate the time needed to handle the responsibilities of
reviewing or approving changes. They are encouraged to add themselves as `emeritus` which mimics the
owner spec, just under the `emeritus` key.

Anything under the `emeritus` key will be ignored by prow for assignment. However, it can still be
referenced by a person looking at the OWNERS file for a possible second or more informed opinion.

When a contributor returns to being more active in that area, they can move themselves back from
emeritus to a regular approver or reviewer.

```yaml
approvers:
- alice
- bob
reviewers:
- alice
- carol
emeritus:
approvers:
- david # 2018-05-02
reviewers:
- emily # 2019-01-05
```

### OWNERS_ALIASES

Each repo may contain at its root an OWNERS_ALIAS file.
Expand Down Expand Up @@ -265,7 +295,8 @@ pieces of prow are used to implement the code review process above.

OWNERS files should be regularly maintained.

We encourage people to self-nominate or self-remove from OWNERS files via PR's. Ideally in the future we could use metrics-driven automation to assist in this process.
We encourage people to self-nominate, self-remove or switch to `emeritus` from OWNERS files via PR's.
Ideally in the future we could use metrics-driven automation to assist in this process.

We should strive to:

Expand Down

0 comments on commit 1c9debd

Please sign in to comment.