Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Minor devstack plugin changes #53

Closed
wants to merge 1 commit into from

Conversation

grahamhayes
Copy link
Contributor

STILL WIP - will update as I walk through the install

What this PR does / why we need it:

  • Swap $BASE_DIR/tools/test-setup.sh and
    $BASE_DIR/tools/install-distro-packages.sh so that go is
    installed in time
  • Ensure systemctl uses --no-pager to avoid pauses when running
    interactively
  • Move the generation of the bindep package list to the $BASE_DIR

Special notes for your reviewer:
STILL WIP - will update as I walk through the install

Release note:

* Swap ``$BASE_DIR/tools/test-setup.sh`` and
  ``$BASE_DIR/tools/install-distro-packages.sh`` so that go is
  installed in time
* Ensure systemctl uses ``--no-pager`` to avoid pauses when running
  interactively
* Move the generation of the bindep package list to the ``$BASE_DIR``
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 26, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: nickrenren

Assign the PR to them by writing /assign @nickrenren in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 26, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 26, 2018
sudo systemctl status docker
sudo systemctl --no-pager daemon-reload
sudo systemctl --no-pager restart docker
sudo systemctl --no-pager status docker
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 'systemctl status' call was removed in PR #50, thats causing the merge conflict.

@dims
Copy link
Member

dims commented Apr 8, 2018

/close

please reopen when you rebase.

Fedosin pushed a commit to Fedosin/cloud-provider-openstack that referenced this pull request Jun 14, 2021
[manila-csi-plugin] Bug 1944655: Ignore proxy connecting to CSI sockets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants