Add internal-network-name networking option #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help in case of multi-nic k8s node deployments. Previously, cloud provider was assigning all addresses in random order and k8s was selecting only one of them. But usually, multi-nic scenario requires to specify which network is "control" and admins want to bind kubelet listening address only to that "control" net. This commit will not affect previous logic until internal-network-name is specified in cloud-config file. Related to: kubernetes#407 Change-Id: I1e4076b853b12020c47529b0590f21523b9d26a8
k8s-ci-robot
added
the
cncf-cla: yes
|
Hi @mogaika. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
needs-ok-to-test
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
k8s-ci-robot
added
the
lgtm
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
/retest |
|
I'd suggest we at least add some info (maybe a followup) patch on how this can be configured to avoid read code to find where to set internal network |
|
Build succeeded.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: zetaab The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/retest |
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
/lgtm |
k8s-ci-robot
added
the
lgtm
openstack-gerrit
pushed a commit
to openstack/magnum
that referenced
this pull request
Apr 2, 2019
When there is more than one NIC attached to an instance, openstack cloud provider returns a random InternalIP back to the host resulting in instability with API server which only talks to a default interface. This patch incorporates the changes made in kubernetes/cloud-provider-openstack#444 which enables OpenStack Cloud Controller Manager to respect the `internal-network-name` in cloud-config file which ensures that InternalIP remains stable. Story: 2005333 Task: 30271 Change-Id: I9e3ad459dd05753b53cb4ce75ee3aed649fef196
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Apr 2, 2019
* Update magnum from branch 'master'
- Merge "Specify internal network to improve stability in a multi-NIC scenario."
- Specify internal network to improve stability in a multi-NIC scenario.
When there is more than one NIC attached to an instance, openstack cloud
provider returns a random InternalIP back to the host resulting in instability
with API server which only talks to a default interface.
This patch incorporates the changes made in
kubernetes/cloud-provider-openstack#444 which enables
OpenStack Cloud Controller Manager to respect the `internal-network-name` in
cloud-config file which ensures that InternalIP remains stable.
Story: 2005333
Task: 30271
Change-Id: I9e3ad459dd05753b53cb4ce75ee3aed649fef196
openstack-gerrit
pushed a commit
to openstack/magnum
that referenced
this pull request
Aug 1, 2019
When there is more than one NIC attached to an instance, openstack cloud provider returns a random InternalIP back to the host resulting in instability with API server which only talks to a default interface. This patch incorporates the changes made in kubernetes/cloud-provider-openstack#444 which enables OpenStack Cloud Controller Manager (OCCM) to respect the `internal-network-name` in cloud-config file which ensures that InternalIP remains stable. Uses a separate cloud-config file for OCCM to ensure in-tree Cinder volumes remain compatible. Change-Id: Idfa52ed2d512e7dc383a556371e896205dd542f9 Story: 2005333 Task: 30271
openstack-gerrit
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 1, 2019
* Update magnum from branch 'master'
- Merge "Add network config to stabilise multi-NIC scenario"
- Add network config to stabilise multi-NIC scenario
When there is more than one NIC attached to an instance, openstack cloud
provider returns a random InternalIP back to the host resulting in instability
with API server which only talks to a default interface.
This patch incorporates the changes made in
kubernetes/cloud-provider-openstack#444 which enables
OpenStack Cloud Controller Manager (OCCM) to respect the
`internal-network-name` in cloud-config file which ensures that InternalIP
remains stable.
Uses a separate cloud-config file for OCCM to ensure in-tree Cinder volumes
remain compatible.
Change-Id: Idfa52ed2d512e7dc383a556371e896205dd542f9
Story: 2005333
Task: 30271
brtkwr
added a commit
to stackhpc/magnum
that referenced
this pull request
Nov 6, 2019
When there is more than one NIC attached to an instance, openstack cloud provider returns a random InternalIP back to the host resulting in instability with API server which only talks to a default interface. This patch incorporates the changes made in kubernetes/cloud-provider-openstack#444 which enables OpenStack Cloud Controller Manager (OCCM) to respect the `internal-network-name` in cloud-config file which ensures that InternalIP remains stable. Uses a separate cloud-config file for OCCM to ensure in-tree Cinder volumes remain compatible. Conflicts: magnum/drivers/common/templates/kubernetes/fragments/write-kube-os-config.sh magnum/drivers/k8s_fedora_atomic_v1/templates/kubemaster.yaml Change-Id: Idfa52ed2d512e7dc383a556371e896205dd542f9 Story: 2005333 Task: 30271 (cherry picked from commit 425fb0f)
brtkwr
added a commit
to stackhpc/magnum
that referenced
this pull request
Nov 8, 2019
When there is more than one NIC attached to an instance, openstack cloud provider returns a random InternalIP back to the host resulting in instability with API server which only talks to a default interface. This patch incorporates the changes made in kubernetes/cloud-provider-openstack#444 which enables OpenStack Cloud Controller Manager (OCCM) to respect the `internal-network-name` in cloud-config file which ensures that InternalIP remains stable. Uses a separate cloud-config file for OCCM to ensure in-tree Cinder volumes remain compatible. Conflicts: magnum/drivers/common/templates/kubernetes/fragments/write-kube-os-config.sh magnum/drivers/k8s_fedora_atomic_v1/templates/kubemaster.yaml Change-Id: Idfa52ed2d512e7dc383a556371e896205dd542f9 Story: 2005333 Task: 30271 (cherry picked from commit 425fb0f)
powellchristoph
pushed a commit
to powellchristoph/cloud-provider-openstack
that referenced
this pull request
Jan 19, 2022
Add internal-network-name networking option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This will help in case of multi-nic k8s node deployments.
Previously, cloud provider was assigning all addresses in random
order and k8s was selecting only one of them. But usually,
multi-nic scenario requires to specify which network is
"control" and admins want to bind kubelet listening address only
to that "control" net.
This commit will not affect previous logic until
internal-network-name is specified in cloud-config file.
Which issue this PR fixes: fixes #407
Special notes for your reviewer:
Release note: