-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[occm] fix ovn security groups #2705
Conversation
/test openstack-cloud-controller-manager-e2e-test |
/kind bug |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kayrus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.31 |
@zetaab: #2705 failed to apply on top of branch "release-1.30":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cherry-pick release-1.31 |
@zetaab: new pull request created: #2713 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it: the main reason for #2699 was that
svcConf.allowedCIDR
was not passed toensureAndUpdateOctaviaSecurityGroup
from updateloadbalancer (it was passed from ensureloadbalancer). However, I compined some of the creating values for svcConf to new function to make it little bit easier to read and remove duplicatesWhich issue this PR fixes(if applicable):
fixes #2699
Special notes for reviewers:
Release note: