Add two test cases for OCCM #2614
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
|
k8s-ci-robot
added
the
cncf-cla: no
|
Hi @dd-georgiev. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
needs-ok-to-test
| kubectl -n $NAMESPACE delete service ${service} | ||
|
|
||
| printf "\n>>>>>>> Checking if Floating IP is still in openstack" | ||
| FIP_IN_OS=`openstack floating ip list --floating-ip-address "$FIP" -f json | jq length` |
There was a problem hiding this comment.
Same here, plus I'd rather rely on ID here to double-check if IP wasn't deleted and recreated.
| printf "\n>>>>>>> Getting the floating IP of the service\n" | ||
| FIP=`kubectl -n $NAMESPACE get svc test-preserve-fip --no-headers| awk '{print $4}'` | ||
| printf "\n>>>>>>> Checking if Floating IP is in openstack" | ||
| FIP_IN_OS=`openstack floating ip list --floating-ip-address "$FIP" -f json | jq length` |
There was a problem hiding this comment.
openstack floating ip show and checking return code?
| wait_for_service_address ${service} | ||
| printf "\n>>>>>>> Checking if Octavia health monitor is matching spec\n" | ||
|
|
||
| HM_ID=`openstack loadbalancer healthmonitor list | grep "$service" | awk '{print $2}'` |
There was a problem hiding this comment.
You could do show with an exact expected name. That could be useful if we'll add new tests with healthmonitors later.
k8s-ci-robot
added
ok-to-test
Interesting, I signed the document (in docusign) multiple times but it still doesn't show up here. |
|
/easycla Let's retry. You can also try checking the troubleshooting page. E.g. I had issues, because I was sending commits signed with a different email than the one I had in GitHub. |
|
/test pull-cloud-provider-openstack-check This one's stuck. |
|
/easycla |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
k8s-ci-robot
removed
the
lgtm
|
New changes are detected. LGTM label has been removed. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
k8s-ci-robot
added
the
lifecycle/stale
|
/test pull-cloud-provider-openstack-check |
|
/remove-lifecycle stale |
k8s-ci-robot
removed
the
lifecycle/stale
What this PR does / why we need it:
I added test cases for testing:
loadbalancer.openstack.org/keep-floatingip: "true"annotation is added to service