Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] validate flavor name, fallback on flavor id (release-1.20) #1402

Merged
merged 1 commit into from
Feb 10, 2021
Merged

[occm] validate flavor name, fallback on flavor id (release-1.20) #1402

merged 1 commit into from
Feb 10, 2021

Conversation

seanschneeweiss
Copy link
Contributor

@seanschneeweiss seanschneeweiss commented Feb 9, 2021 •
edited
Loading

What this PR does / why we need it:
Cherry picked from #1364

Which issue this PR fixes(if applicable):

Special notes for reviewers:

Release note:

NONE

Sean Schneeweiss [email protected], Daimler TSS GmbH, legal info/Impressum

@seanschneeweiss
[occm] validate flavor name, fallback on flavor id
91902bf 
The node.kubernetes.io/instance-type label accepts alphanumeric
characters, '-', '_', and '.' only. If the flavor name contains
invalid characters, the flavor id is used instead.

Signed-off-by: Sean Schneeweiss <[email protected]>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 9, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @seanschneeweiss. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 9, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build failed.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 9, 2021

Build succeeded.

@seanschneeweiss seanschneeweiss mentioned this pull request Feb 9, 2021
Merged
@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 10, 2021
@lingxiankong
Copy link
Contributor

/retest

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 10, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 10, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 10, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 10, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 10, 2021

Build succeeded.

@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 10, 2021

Build succeeded.

@ramineni
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2021
@theopenlab-ci
Copy link

theopenlab-ci bot commented Feb 10, 2021

Build succeeded.

@lingxiankong
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lingxiankong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit 8843da4 into kubernetes:release-1.20 Feb 10, 2021
This was referenced May 18, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dims dims Awaiting requested review from dims

@FengyunPan2 FengyunPan2 Awaiting requested review from FengyunPan2

Assignees

@ramineni ramineni

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@seanschneeweiss @k8s-ci-robot @jichenjc @lingxiankong @ramineni