Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement GET_VOLUME_STATS node capability #669

Closed
ramineni opened this issue Jun 27, 2019 · 11 comments · Fixed by #941
Closed

Implement GET_VOLUME_STATS node capability #669

ramineni opened this issue Jun 27, 2019 · 11 comments · Fixed by #941
Assignees
@ramineni
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@ramineni
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
NodeGetVolumeStats capability is missing in nodeserver. https://github.com/container-storage-interface/spec/blob/master/spec.md#nodegetvolumestats , This issue is to track the same.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • openstack-cloud-controller-manager version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 27, 2019
@ramineni
Copy link
Contributor Author

/assign

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2019
@ramineni
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 25, 2019
@adisky
Copy link
Contributor

adisky commented Dec 2, 2019

/priority-important-soon

@adisky
Copy link
Contributor

adisky commented Dec 2, 2019

/priority critical-urgent
This needs to be implemented as soon as possible, as intree cinder driver supports metrics, we need to add support for CSI as well.
cc @chrigl @ramineni

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 2, 2019
@adisky adisky removed the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Dec 3, 2019
@adisky
Copy link
Contributor

adisky commented Dec 3, 2019

/priority important-soon It seems the state of metrics is not clear for CSI and migration
https://github.com/orgs/kubernetes-csi/projects/13

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 3, 2019
@zuzzas zuzzas mentioned this issue Feb 19, 2020
Merged
9 tasks
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2020
@ramineni
Copy link
Contributor Author

ramineni commented Mar 2, 2020

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Mar 2, 2020
@ramineni
Copy link
Contributor Author

ramineni commented Mar 2, 2020

/assign @zuzzas

@k8s-ci-robot
Copy link
Contributor

@ramineni: GitHub didn't allow me to assign the following users: zuzzas.

Note that only kubernetes members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @zuzzas

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zuzzas
Copy link
Contributor

zuzzas commented Mar 2, 2020

I'll submit all the required changes tonight.

@nsteinmetz nsteinmetz mentioned this issue Mar 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ramineni ramineni

Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[cinder-csi-plugin] NodeGetVolumeStats() implementation flant/cloud-provider-openstack
5 participants
@zuzzas @ramineni @adisky @k8s-ci-robot @fejta-bot