Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[occm] Not all OpenStack providers support AllowedAddressPairs #2491

Closed
sircthulhu opened this issue Dec 5, 2023 · 0 comments · Fixed by #2492
Closed

[occm] Not all OpenStack providers support AllowedAddressPairs #2491

sircthulhu opened this issue Dec 5, 2023 · 0 comments · Fixed by #2492
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sircthulhu
Copy link
Contributor

FEATURE
/kind feature
What happened:
I've experienced an issue with routing controller on one of OpenStack cloud providers. This provider has disabled allowed_address_pairs for network ports, whereas OCCM tries to install them and reverts all changes (including created route in router).

I can implement this if maintainers agree with this feature.

What you expected to happen:
Config option to disable adding allowed_address_pairs for network port, so that users could disable this feature as it is not necessary on VMs of such providers.

How to reproduce it:
Have no idea, as I'm just a customer.

Anything else we need to know?:
Native routing works fine without altering allowed_address_pairs on VMs' ports.

Environment:

  • openstack-cloud-controller-manager(or other related binary) version: 1.28.1
  • OpenStack version: Neutron v2.0
  • Others: Kubernetes 1.28.0
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Dec 5, 2023
sircthulhu added a commit to sircthulhu/cloud-provider-openstack that referenced this issue Dec 5, 2023
@sircthulhu
Implement config option to skip changing allowed_address_pairs on rou…
08b4fea 
…tes creation

Not all cloud providers support allowed_address_pairs on VM ports, and tries to configure them return errors
implements kubernetes#2491
@sircthulhu sircthulhu mentioned this issue Dec 5, 2023
Merged
sircthulhu added a commit to sircthulhu/cloud-provider-openstack that referenced this issue Dec 5, 2023
@sircthulhu
Ignore allowed_address_pairs if not available
ba48391 
Not all cloud providers support allowed_address_pairs on VM ports, and tries to configure them return errors
fixes kubernetes#2491
@kayrus kayrus mentioned this issue Dec 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[occm] Not all OpenStack providers support AllowedAddressPairs sircthulhu/cloud-provider-openstack
2 participants
@sircthulhu @k8s-ci-robot