Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[All] update node-role.kubernetes.io/master=>node-role.kubernetes.io/control-plane #1839

Closed
jichenjc opened this issue Apr 20, 2022 · 3 comments · Fixed by #1875
Closed

[All] update node-role.kubernetes.io/master=>node-role.kubernetes.io/control-plane #1839

jichenjc opened this issue Apr 20, 2022 · 3 comments · Fixed by #1875
Milestone

Comments

@jichenjc
Copy link
Contributor

jichenjc commented Apr 20, 2022

Is this a BUG REPORT or FEATURE REQUEST?:

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:

kubernetes/kubeadm#2200
kubernetes-sigs/cluster-api#5919
has further info

we have following occurrance need to be updated

# grep node-role.kubernetes.io * -r
charts/openstack-cloud-controller-manager/values.yaml:#   node-role.kubernetes.io/controlplane: "true"
charts/openstack-cloud-controller-manager/values.yaml:#   - key: node-role.kubernetes.io/controlplane
charts/openstack-cloud-controller-manager/values.yaml:#   - key: node-role.kubernetes.io/etcd
docs/magnum-auto-healer/using-magnum-auto-healer.md:        node-role.kubernetes.io/master: ""
manifests/controller-manager/openstack-cloud-controller-manager-ds.yaml:        node-role.kubernetes.io/master: ""
manifests/controller-manager/openstack-cloud-controller-manager-ds.yaml:      - key: node-role.kubernetes.io/master
manifests/magnum-auto-healer/magnum-auto-healer.yaml:        node-role.kubernetes.io/master: ""
pkg/ingress/controller/controller.go:   DeprecatedLabelNodeRoleMaster = "node-role.kubernetes.io/master"
pkg/autohealing/controller/controller.go:       LabelNodeRoleMaster = "node-role.kubernetes.io/master"
tests/playbooks/roles/install-cpo-occm/tasks/main.yaml:            - key: node-role.kubernetes.io/master

What you expected to happen:

How to reproduce it:

Anything else we need to know?:

Environment:

  • openstack-cloud-controller-manager(or other related binary) version:
  • OpenStack version:
  • Others:
@jichenjc
Copy link
Contributor Author

jichenjc commented May 9, 2022

#1840 is for OCCM only, there are more need to be updated

@chrigl chrigl added this to the v1.24 milestone May 16, 2022
@chrigl
Copy link
Contributor

chrigl commented May 20, 2022

/close

fixed by #1875

@k8s-ci-robot
Copy link
Contributor

@chrigl: Closing this issue.

In response to this:

/close

fixed by #1875

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants