Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update pause-win image to the new one k8s.gcr.io/pause:3.4.1 #186

Merged
merged 1 commit into from
Feb 19, 2021
Merged

test: update pause-win image to the new one k8s.gcr.io/pause:3.4.1 #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cluster/gce/windows/k8s-node-setup.psm1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@
# - Document functions using proper syntax:
# https://technet.microsoft.com/en-us/library/hh847834(v=wps.620).aspx

$INFRA_CONTAINER = 'gcr.io/gke-release/pause-win:1.1.0'
$INFRA_CONTAINER = 'k8s.gcr.io/pause:3.4.1'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please let's add this to build/dependencies.yaml in the "dependents" entry so we don't de-sync it again 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, did not follow you, add where? should we remove it from this file? I'm sorry for the dumb question, not clear to me

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not at all, sorry somehow I thought I'd already seen you interact with this:
https://github.com/kubernetes/kubernetes/blob/473af0b8d1951b5c362df60925bb8d9fb007fab9/build/dependencies.yaml#L162

we have a presubmit that ensures that the versions are in sync based on the (filepath, regex) specs in that file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add these references to the pause image to that list so when pause is updated again someday the presubmit will catch if these new references added in this PR aren't updated

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LOL wrong repo. bentheelder is taking a long nap soon.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wishful thinking. sorry about that!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

$GCE_METADATA_SERVER = "169.254.169.254"
# The "management" interface is used by the kubelet and by Windows pods to talk
# to the rest of the Kubernetes cluster *without NAT*. This interface does not
Expand Down
2 changes: 1 addition & 1 deletion cluster/gce/windows/smoke-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,7 +358,7 @@ spec:
spec:
containers:
- name: pause-win
image: gcr.io/gke-release/pause-win:1.1.0
image: k8s.gcr.io/pause:3.4.1
nodeSelector:
kubernetes.io/os: windows
tolerations:
Expand Down