-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor to use legacy cloud provider #61
Refactor to use legacy cloud provider #61
Conversation
/cc @M00nF1sh |
436555f
to
9c8b8bf
Compare
9c8b8bf
to
767f21d
Compare
Followed openstack's approach, which involves defining the cobra command, and additionally redefining the |
/cc @andrewsykim |
// Use our version instead of the Kubernetes formatted version | ||
versionFlag := cmd.Flags().Lookup("version") | ||
if versionFlag.Value.String() == "true" { | ||
klog.V(1).Infof("%s version: %s", cmd.Name(), version) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
exit after printing version?
return controllers | ||
} | ||
|
||
func startCloudNodeController(ctx *cloudcontrollerconfig.CompletedConfig, cloud cloudprovider.Interface, stopCh <-chan struct{}) (http.Handler, bool, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you call NewCloudControllerManagerCommand() in main.go, you should get all of this with it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I saw that. It would be easier but my plan was to start with this and then eventually replace/remove the dependencies on k/k, which I think will be easier if we start here.
* This is starting with v1.15.0
767f21d
to
5e10840
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is an good starting point where we can iterate from :D
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: M00nF1sh, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi, I'm a newcomer and would like to contribute to this project. Where should I work on after this migration? In kubernetes' main repo staging area as the legacy-cloud-provider says? |
@geckofu |
i feel like the better approach would have been to go in the opposite direction, ie have the legacy cloud in k8s main repo depend on the code in this repo. as is it just erases most of the progress made in moving the provider out of tree. |
@kapilt that's a good point but there's a few reasons for not importing this repo back from kubernetes/kubernetes:
|
What type of PR is this?
What this PR does / why we need it:
In order to start using this repo to build valid cloud-controller-manager binaries and begin adding tests, we need to migrate to the legacy-cloud-provider.