-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set custom service account names for controllers #237
Set custom service account names for controllers #237
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0fe2c47
to
d9dc769
Compare
d9dc769
to
c8b7024
Compare
@nckturner: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@nckturner: Failed to re-open PR: state cannot be changed. The custom-service-account-names branch was force-pushed or recreated. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
What this PR does / why we need it:
If kubernetes/kubernetes#103178 is merged, we can set custom controller client/service accounts names, and use RBAC that is managed in this repository, rather than relying on the upstream bootstrapped RBAC, like the "node-controller" role.
Ref: kubernetes/cloud-provider#48.
Depends on: kubernetes/kubernetes#103178
Depends on: kubernetes/kubernetes#103710
Also set --configure-cloud-routes to false in hack/local-up-cluster.sh, because a recent change in the route controller means that the route controller starts now when it didn't before. We don't want the route controller to start if we are using the VPC CNI plugin, for example, but we can still override the flag if we want to test with kubenet. (Arguably this should be the other way around, but I'm basing the default off my own most frequent testing needs).
Does this PR introduce a user-facing change?:
/hold