-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial sections for docs site #102
Conversation
Signed-off-by: Andrew Sy Kim <[email protected]>
lgtm as a skeleton to fill in. |
* [Prerequisites](prerequisites.md) | ||
* [Getting Started](getting_started.md) | ||
* [Service LoadBalancers](service_loadbalancers.md) | ||
* [Known Limitations](known_limitations.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What else do we need to add here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EBS is going off to CSI now?
IAM perms is usually the key thing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, any default tags the CPI set might be helpful to document.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IAM perms is usually the key thing.
Agreed, I think this would go into the Prerequisites section I imagine
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, any default tags the CPI set might be helpful to document.
Wondering what section this would belong to. Maybe a "Resource Management" section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we want node specific stuff in these docs too? We could have a section on the registry credential provider stuff. Also kubelet's interaction with the cloud provider, including node names, hostname override.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for a section on Nodes. Will add it shortly
/hold Pending discussion on doc template |
/assign @justinsb @nckturner |
Let's merge this so we can start adding to it. |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: andrewsykim, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Andrew Sy Kim [email protected]
What type of PR is this?
/kind documentation
What this PR does / why we need it:
We're trying to improve documentation on the AWS cloud provider. Before divvying up the work, I would like agreement on what the content should look like at a high level. I've added some initial sections that I think is worth covering, I'd like to use this PR to discuss what other content we should include.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?: