support provider id in kubernetes api format #177
Conversation
k8s-ci-robot
added
cncf-cla: yes
| // Use '.' to separate providerID which looks like 'cn-hangzhou.i-v98dklsmnxkkgiiil7'. The format of "REGION.NODEID" | ||
| // providerID | ||
| // 1) the id of the instance in the alicloud API. Use '.' to separate providerID which looks like 'cn-hangzhou.i-v98dklsmnxkkgiiil7'. The format of "REGION.NODEID" | ||
| // 2) the id for an instance in the kubernetes API, which has 'alicloud://' prefix. e.g. alicloud://cn-hangzhou.i-v98dklsmnxkkgiiil7 |
There was a problem hiding this comment.
We'd better make it like alicloud:///cn-hangzhou/i-v98dklsmnxkkgiiil7, which is consistent with the standard format <cloudProvider>://<optional>/<segments>/<provider id>.
There was a problem hiding this comment.
provider_id in alicloud is like 'cn-hangzhou.i-v98dklsmnxkkgiiil7'. The format is "REGION.NODEID"
There was a problem hiding this comment.
OK. Let's keep the original design alicloud://cn-hangzhou.i-v98dklsmnxkkgiiil7 for now. It seems that it can be parsed with
https://github.com/kubernetes-sigs/cluster-api/blob/master/controllers/noderefutil/providerid.go#L47
|
Fixes #138 |
gujingit
force-pushed
the
feature/providerID
branch
from
e345e95 to
dc81029
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
support provider id in kubernetes api format
No description provided.